Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1278605

Re: [PATCH RFT] arm64: kasan: Make KASAN work with 16K pages + 48 bit VA

Show all headers | View raw

On 11/26/2015 07:40 PM, Ard Biesheuvel wrote:
> On 26 November 2015 at 14:14, Andrey Ryabinin <aryabinin@virtuozzo.com> wrote:
>> Currently kasan assumes that shadow memory covers one or more entire PGDs.
>> That's not true for 16K pages + 48bit VA space, where PGDIR_SIZE is bigger
>> than the whole shadow memory.
>>
>> This patch tries to fix that case.
>> clear_page_tables() is a new replacement of clear_pgs(). Instead of always
>> clearing pgds it clears top level page table entries that entirely belongs
>> to shadow memory.
>> In addition to 'tmp_pg_dir' we now have 'tmp_pud' which is used to store
>> puds that now might be cleared by clear_page_tables.
>>
>> Reported-by: Suzuki K. Poulose <Suzuki.Poulose@arm.com>
>> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
> 
> I would argue that the Kasan code is complicated enough, and we should
> avoid complicating it even further for a configuration that is highly
> theoretical in nature.
> 
> In a 16k configuration, the 4th level only adds a single bit of VA
> space (which is, as I understand it, exactly the issue you need to
> address here since the top level page table has only 2 entries and
> hence does not divide by 8 cleanly), which means you are better off
> using 3 levels unless you *really* need more than 128 TB of VA space.
> 
> So can't we just live with the limitation, and keep the current code?
 

No objections from my side. Let's keep the current code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RFT] arm64: kasan: Make KASAN work with 16K pages + 48 bit VA Andrey Ryabinin <aryabinin@virtuozzo.com> - 2015-11-26 14:20 +0100
  Re: [PATCH RFT] arm64: kasan: Make KASAN work with 16K pages + 48  bit VA Mark Rutland <mark.rutland@arm.com> - 2015-11-26 15:50 +0100
    Re: [PATCH RFT] arm64: kasan: Make KASAN work with 16K pages + 48 bit  VA Andrey Ryabinin <aryabinin@virtuozzo.com> - 2015-11-26 16:50 +0100
      Re: [PATCH RFT] arm64: kasan: Make KASAN work with 16K pages + 48  bit VA Mark Rutland <mark.rutland@arm.com> - 2015-11-26 17:30 +0100
        Re: [PATCH RFT] arm64: kasan: Make KASAN work with 16K pages + 48 bit  VA Andrey Ryabinin <aryabinin@virtuozzo.com> - 2015-11-26 17:50 +0100
          Re: [PATCH RFT] arm64: kasan: Make KASAN work with 16K pages + 48  bit VA Mark Rutland <mark.rutland@arm.com> - 2015-11-26 18:10 +0100
  Re: [PATCH RFT] arm64: kasan: Make KASAN work with 16K pages + 48 bit VA Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2015-11-26 17:50 +0100
    Re: [PATCH RFT] arm64: kasan: Make KASAN work with 16K pages + 48 bit  VA Andrey Ryabinin <aryabinin@virtuozzo.com> - 2015-11-27 09:20 +0100
      Re: [PATCH RFT] arm64: kasan: Make KASAN work with 16K pages + 48  bit VA Catalin Marinas <catalin.marinas@arm.com> - 2015-11-27 10:40 +0100
        Re: [PATCH RFT] arm64: kasan: Make KASAN work with 16K pages + 48  bit VA Will Deacon <will.deacon@arm.com> - 2015-11-27 11:10 +0100
          Re: [PATCH RFT] arm64: kasan: Make KASAN work with 16K pages + 48 bit VA Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2015-11-27 11:40 +0100
          Re: [PATCH RFT] arm64: kasan: Make KASAN work with 16K pages + 48  bit VA Catalin Marinas <catalin.marinas@arm.com> - 2015-11-27 15:20 +0100

csiph-web