Re: [PATCH] btrfs: use kbasename in btrfsic_mount

Path	csiph.com!news.mixmin.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!eternal-september.org!feeder.eternal-september.org!Xbb.tags.giganews.com!border1.nntp.ams1.giganews.com!nntp.giganews.com!news.panservice.it!bofh.it!news.nic.it!robomod
From	kbuild test robot <lkp@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] btrfs: use kbasename in btrfsic_mount
Date	Fri, 27 Nov 2015 09:40:02 +0100
Message-ID	<qzmJs-pZ-7@gated-at.bofh.it> (permalink)
References	<qzmq5-ij-5@gated-at.bofh.it>
X-Original-To	Rasmus Villemoes <linux@rasmusvillemoes.dk>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.20,351,1444719600"; d="gz'50?scan'50,208,50";a="695377105"
MIME-Version	1.0
Content-Type	multipart/mixed; boundary="cNdxnHkX5QqsyA0e"
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
X-Sa-Exim-Connect-IP	<locally generated>
X-Sa-Exim-Mail-From	fengguang.wu@intel.com
X-Sa-Exim-Scanned	No (on bee); SAEximRunCond expanded to false
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	489
Organization	linux.* mail to news gateway
X-Original-Cc	kbuild-all@01.org, Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>, David Sterba <dsterba@suse.com>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Fri, 27 Nov 2015 16:32:49 +0800
X-Original-Message-ID	<201511271640.QHZdu1xB%fengguang.wu@intel.com>
X-Original-References	<1448611892-26144-1-git-send-email-linux@rasmusvillemoes.dk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1278621

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Rasmus,

[auto build test WARNING on: v4.4-rc2]
[also build test WARNING on: next-20151127]

url:    https://github.com/0day-ci/linux/commits/Rasmus-Villemoes/btrfs-use-kbasename-in-btrfsic_mount/20151127-161249
config: i386-randconfig-s1-201547 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   fs/btrfs/check-integrity.c: In function 'btrfsic_mount':
>> fs/btrfs/check-integrity.c:3140:5: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
      p = kbasename(ds->name);
        ^

vim +/const +3140 fs/btrfs/check-integrity.c

  3124			char *p;
  3125	
  3126			if (!device->bdev || !device->name)
  3127				continue;
  3128	
  3129			ds = btrfsic_dev_state_alloc();
  3130			if (NULL == ds) {
  3131				printk(KERN_INFO
  3132				       "btrfs check-integrity: kmalloc() failed!\n");
  3133				mutex_unlock(&btrfsic_mutex);
  3134				return -1;
  3135			}
  3136			ds->bdev = device->bdev;
  3137			ds->state = state;
  3138			bdevname(ds->bdev, ds->name);
  3139			ds->name[BDEVNAME_SIZE - 1] = '\0';
> 3140			p = kbasename(ds->name);
  3141			strlcpy(ds->name, p, sizeof(ds->name));
  3142			btrfsic_dev_state_hashtable_add(ds,
  3143							&btrfsic_dev_state_hashtable);
  3144		}
  3145	
  3146		ret = btrfsic_process_superblock(state, fs_devices);
  3147		if (0 != ret) {
  3148			mutex_unlock(&btrfsic_mutex);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Thread

[PATCH] btrfs: use kbasename in btrfsic_mount Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-11-27 09:20 +0100
  Re: [PATCH] btrfs: use kbasename in btrfsic_mount kbuild test robot <lkp@intel.com> - 2015-11-27 09:40 +0100
    Re: [PATCH] btrfs: use kbasename in btrfsic_mount Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-11-27 09:40 +0100
  Re: [PATCH] btrfs: use kbasename in btrfsic_mount David Sterba <dsterba@suse.cz> - 2015-11-27 09:40 +0100
  Re: [PATCH] btrfs: use kbasename in btrfsic_mount Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-27 10:40 +0100

csiph-web