[bug] mei_fasync() bogosity

From	Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups	linux.kernel
Subject	[bug] mei_fasync() bogosity
Date	2015-11-27 05:30 +0100
Message-ID	<qziPw-6lh-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

in "mei: implement fasync for event notification" a ->fasync() instance is
added as

static int mei_fasync(int fd, struct file *file, int band)
{

	struct mei_cl *cl = file->private_data;

	if (!mei_cl_is_connected(cl))
		return POLLERR;

	return fasync_helper(fd, file, band, &cl->ev_async);
}

Valid return values for ->fasync() are 0, 1 and -E...; 8 (aka POLLERR) is not.
What had been intended there?  -ENODEV?  Some other error?  As it is, the
thing is broken.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[bug] mei_fasync() bogosity Al Viro <viro@ZenIV.linux.org.uk> - 2015-11-27 05:30 +0100

csiph-web