Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1279095

Re: [PATCH 0/3] cgroup: fix race between cgroup_post_fork() and cgroup_migrate()

Show all headers | View raw

On 2015/11/28 2:57, Oleg Nesterov wrote:
> On 11/26, Oleg Nesterov wrote:
>>
>> OK. I do not know what exactly do you mean, perhaps if you fix this problem
>> the race between fork and attach goes away and in this case the fix I sent
>> is not needed?
>
> Otherwise please consider this series.
>
> Slightly tested, seems to work; please review.
>

Allowing tasks migrating between cgroups while forking is problematic. I'm more
than glad to see those changes.

Acked-by: Zefan Li <lizefan@huawei.com>

> Oleg.
>
>   include/linux/cgroup-defs.h   |   12 ++------
>   include/linux/cgroup.h        |   19 ++++---------
>   include/linux/cgroup_subsys.h |   18 ------------
>   kernel/cgroup.c               |   30 +++++----------------
>   kernel/cgroup_freezer.c       |    2 +-
>   kernel/cgroup_pids.c          |   58 +++++++---------------------------------
>   kernel/fork.c                 |   16 ++++-------
>   kernel/sched/core.c           |    2 +-
>   8 files changed, 34 insertions(+), 123 deletions(-)
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] cgroup: fix race between cgroup_post_fork() and  cgroup_migrate() Oleg Nesterov <oleg@redhat.com> - 2015-11-27 20:00 +0100
  [PATCH 1/3] cgroup: pids: fix race between cgroup_post_fork() and  cgroup_migrate() Oleg Nesterov <oleg@redhat.com> - 2015-11-27 20:00 +0100
  [PATCH 2/3] cgroup: pids: kill pids_fork(), simplify  pids_can_fork() and pids_cancel_fork() Oleg Nesterov <oleg@redhat.com> - 2015-11-27 20:00 +0100
  [PATCH 3/3] cgroup: kill cgrp_ss_priv[CGROUP_CANFORK_COUNT] and  friends Oleg Nesterov <oleg@redhat.com> - 2015-11-27 20:00 +0100
  Re: [PATCH 0/3] cgroup: fix race between cgroup_post_fork() and  cgroup_migrate() Zefan Li <lizefan@huawei.com> - 2015-11-28 04:20 +0100
    Re: [PATCH 0/3] cgroup: fix race between cgroup_post_fork() and  cgroup_migrate() Oleg Nesterov <oleg@redhat.com> - 2015-11-30 16:20 +0100
  Re: [PATCH 0/3] cgroup: fix race between cgroup_post_fork() and  cgroup_migrate() Tejun Heo <tj@kernel.org> - 2015-11-30 16:00 +0100

csiph-web