[PATCH 02/12] tty: Remove !tty check from free_tty_struct()

From	Peter Hurley <peter@hurleysoftware.com>
Newsgroups	linux.kernel
Subject	[PATCH 02/12] tty: Remove !tty check from free_tty_struct()
Date	2015-11-28 03:30 +0100
Message-ID	<qzDqV-2GJ-9@gated-at.bofh.it> (permalink)
References	<qzDqV-2GJ-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

free_tty_struct() is never called with NULL tty; the two call sites
would already have faulted on earlier access.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
 drivers/tty/tty_io.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index 153b7b8..76e4ae0 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -171,8 +171,6 @@ static void release_tty(struct tty_struct *tty, int idx);
 
 void free_tty_struct(struct tty_struct *tty)
 {
-	if (!tty)
-		return;
 	tty_ldisc_deinit(tty);
 	put_device(tty->dev);
 	kfree(tty->write_buf);
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 02/12] tty: Remove !tty check from free_tty_struct() Peter Hurley <peter@hurleysoftware.com> - 2015-11-28 03:30 +0100

csiph-web