Re: [PATCH 02/12] statx: Provide IOC flags for Windows fs attributes

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/12] statx: Provide IOC flags for Windows fs attributes
Date	2015-11-26 17:10 +0100
Message-ID	<qz7ho-7tT-1@gated-at.bofh.it> (permalink)
References	<qz6Om-71A-23@gated-at.bofh.it> <qyrUS-43K-19@gated-at.bofh.it> <qwVkl-6h-3@gated-at.bofh.it> <qwVkm-6h-33@gated-at.bofh.it> <qz6Om-71A-23@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

David Howells <dhowells@redhat.com> wrote:

> > As a result, I would suggest that we not try to use the
> > FS_IOC_[GS]ETFLAGS number scheme for any new interface, so we're at
> > least not making a bad situation worse.
> > 
> > The only reason why some other file systems have chosen to use
> > FS_IOC_[GS]ETFLAGS, instead of defining their own ioctl, is so they
> > can use lsattr/chattr from e2fsprogs instead of creating their own
> > utility.  But for statx, there isn't a good reason use the same flags
> > number space.  At the very least, can we use a new flags field for the
> > Windows file attributes?  It's not like lsattr/chattr has the ability
> > to set those flags today anyway.  So we might as well use a new flags
> > field and a new flags numberspace for them.
> 
> Hmmm...  I was trying to make it so that these bits would be saved to disk as
> part of the IOC flags so that Samba could make use of them.  I guess they'll
> have to be stored in an xattr instead.

Or as Dave Chinner suggested, I can put them elsewhere and let the FS deal
with them in its own way.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 02/12] statx: Provide IOC flags for Windows fs attributes David Howells <dhowells@redhat.com> - 2015-11-20 16:00 +0100
  Re: [PATCH 02/12] statx: Provide IOC flags for Windows fs attributes Theodore Ts'o <tytso@mit.edu> - 2015-11-24 21:00 +0100
    Re: [PATCH 02/12] statx: Provide IOC flags for Windows fs attributes David Howells <dhowells@redhat.com> - 2015-11-26 16:40 +0100
      Re: [PATCH 02/12] statx: Provide IOC flags for Windows fs attributes David Howells <dhowells@redhat.com> - 2015-11-26 17:10 +0100
      Re: [PATCH 02/12] statx: Provide IOC flags for Windows fs attributes Andreas Dilger <adilger@dilger.ca> - 2015-11-26 23:20 +0100

csiph-web