Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1278301

Re: [PATCH?] race between cgroup_subsys->fork() and cgroup_migrate()

Show all headers | View raw

On 11/25, Tejun Heo wrote:
>
> On Wed, Nov 25, 2015 at 02:51:38PM -0500, Tejun Heo wrote:
> > Sounds perfect.  As this needs to go through -stable, can you please
> > resend the patch with proper description and SOB?  Please also update
> > the now incorrect comment in can_attach.

OK, will do tomorrow (sorry, can't do today).

> Ooh, the patch triggers RCU warning from task_css().  It's spurious
> and I think the right thing to do at least for now is using
> task_css_check() and explain what's going on.

WARN_ON() in pids_fork() I guess. Thanks. I didn't expect you will actually
apply this patch, I didn't even try to compile it ;)

Plus this patch forgets to unconditionalize another threadgroup_change_end()
in the error path of copy_process().

Again, if we do this, we can make other cleanups/simplifications. For example,
we can kill cgrp_ss_priv[CGROUP_CANFORK_COUNT] in copy_process().

But I see another email from you, will reply in a minute.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH?] race between cgroup_subsys->fork() and cgroup_migrate() Oleg Nesterov <oleg@redhat.com> - 2015-11-25 17:40 +0100
  Re: [PATCH?] race between cgroup_subsys->fork() and cgroup_migrate() Tejun Heo <tj@kernel.org> - 2015-11-25 21:00 +0100
    Re: [PATCH?] race between cgroup_subsys->fork() and cgroup_migrate() Tejun Heo <tj@kernel.org> - 2015-11-25 21:00 +0100
      Re: [PATCH?] race between cgroup_subsys->fork() and cgroup_migrate() Tejun Heo <tj@kernel.org> - 2015-11-25 21:50 +0100
        Re: [PATCH?] race between cgroup_subsys->fork() and  cgroup_migrate() Oleg Nesterov <oleg@redhat.com> - 2015-11-26 17:10 +0100
      Re: [PATCH?] race between cgroup_subsys->fork() and  cgroup_migrate() Oleg Nesterov <oleg@redhat.com> - 2015-11-26 16:40 +0100
        Re: [PATCH?] race between cgroup_subsys->fork() and cgroup_migrate() Aleksa Sarai <cyphar@cyphar.com> - 2015-11-27 00:40 +0100

csiph-web