Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1278082

Re: [PATCH 1/3] perf top: Fix freeze on --call-graph flat/folded

Show all headers | View raw

On Thu, Nov 26, 2015 at 04:08:18PM +0900, Namhyung Kim wrote:
> The callchain rbtree is rebuilt periodically, so it needs to
> reinitialize the root everytime.  Otherwise it can be stuck in the
> rbtree insertion with stale pointers.
> 
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  tools/perf/util/callchain.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
> index fc3b1e0d09ee..564377d2bebf 100644
> --- a/tools/perf/util/callchain.c
> +++ b/tools/perf/util/callchain.c
> @@ -290,6 +290,7 @@ static void
>  sort_chain_flat(struct rb_root *rb_root, struct callchain_root *root,
>  		u64 min_hit, struct callchain_param *param __maybe_unused)
>  {
> +	*rb_root = RB_ROOT;

it seems ok, but I did not find how this could be called twice?

the only sort I can see is done within:
  __hists__insert_output_entry

do we allow resorting of the callchains?

thanks,
jirka

>  	__sort_chain_flat(rb_root, &root->node, min_hit);
>  }
>  
> -- 
> 2.6.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] perf top: Fix freeze on --call-graph flat/folded Namhyung Kim <namhyung@kernel.org> - 2015-11-26 08:10 +0100
  [PATCH 2/3] perf callchain: Stop resolving callchains after invalid address Namhyung Kim <namhyung@kernel.org> - 2015-11-26 08:10 +0100
    Re: [PATCH 2/3] perf callchain: Stop resolving callchains after  invalid address Ingo Molnar <mingo@kernel.org> - 2015-11-26 08:50 +0100
      Re: [PATCH 2/3] perf callchain: Stop resolving callchains after  invalid address Namhyung Kim <namhyung@kernel.org> - 2015-11-26 15:20 +0100
        Re: [PATCH 2/3] perf callchain: Stop resolving callchains after  invalid address Ingo Molnar <mingo@kernel.org> - 2015-11-27 08:50 +0100
    Re: [PATCH 2/3] perf callchain: Stop resolving callchains after  invalid address David Ahern <dsahern@gmail.com> - 2015-11-26 14:20 +0100
      Re: [PATCH 2/3] perf callchain: Stop resolving callchains after  invalid address Namhyung Kim <namhyung@kernel.org> - 2015-11-26 16:10 +0100
        Re: [PATCH 2/3] perf callchain: Stop resolving callchains after  invalid address David Ahern <dsahern@gmail.com> - 2015-11-26 16:50 +0100
          Re: [PATCH 2/3] perf callchain: Stop resolving callchains after  invalid address Jiri Olsa <jolsa@redhat.com> - 2015-11-26 17:00 +0100
            Re: [PATCH 2/3] perf callchain: Stop resolving callchains after  invalid address Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-26 17:20 +0100
  Re: [PATCH 1/3] perf top: Fix freeze on --call-graph flat/folded Jiri Olsa <jolsa@redhat.com> - 2015-11-26 09:40 +0100
    Re: [PATCH 1/3] perf top: Fix freeze on --call-graph flat/folded Namhyung Kim <namhyung@kernel.org> - 2015-11-26 15:00 +0100
      Re: [PATCH 1/3] perf top: Fix freeze on --call-graph flat/folded Jiri Olsa <jolsa@redhat.com> - 2015-11-26 15:10 +0100
        Re: [PATCH 1/3] perf top: Fix freeze on --call-graph flat/folded Namhyung Kim <namhyung@kernel.org> - 2015-11-26 16:20 +0100
          Re: [PATCH 1/3] perf top: Fix freeze on --call-graph flat/folded Jiri Olsa <jolsa@redhat.com> - 2015-11-26 16:30 +0100
  Re: [PATCH 1/3] perf top: Fix freeze on --call-graph flat/folded Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-26 17:40 +0100
  [tip:perf/core] perf top: Fix freeze on --call-graph flat/folded tip-bot for Namhyung Kim <tipbot@zytor.com> - 2015-11-27 08:50 +0100

csiph-web