Re: [PATCH 6/9] rtc-pcf2123: avoid resetting the clock if possible

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/9] rtc-pcf2123: avoid resetting the clock if possible
Date	2015-11-25 00:30 +0100
Message-ID	<qyvc6-6mi-27@gated-at.bofh.it> (permalink)
References	<qr8kh-2go-9@gated-at.bofh.it> <qr8kh-2go-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 04/11/2015 at 07:36:37 -0800, Joshua Clayton wrote :
> +	ret = pcf2123_rtc_read_time(dev, &tm);
> +	if (ret < 0)
> +		return false;
> +
> +	if (rtc_valid_tm(&tm) < 0) {
> +		dev_err(dev, "retrieved date/time is not valid.\n");
> +		return false;
> +	}
> +

I would remove that test as basically, the date/time will only be valid
when OSC_HAS_STOPPED is not set.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 6/9] rtc-pcf2123: avoid resetting the clock if possible Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-11-25 00:30 +0100

csiph-web