Re: [PATCH] drivers: staging: vme: Fixed code style issues

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers: staging: vme: Fixed code style issues
Date	2015-11-25 00:30 +0100
Message-ID	<qyvc6-6mi-17@gated-at.bofh.it> (permalink)
References	<qusPv-2xY-3@gated-at.bofh.it> <quvDH-4l0-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Nov 13, 2015 at 11:04:08PM +0000, Martyn Welch wrote:
> 
> 
> On 13/11/15 20:01, Egor Uleyskiy wrote:
> >From: Egor Uleyskiy <egor.ulieiskii@gmail.com>
> >
> >* Fixed indention
> >* Deleted extra empty lines
> >* Constructions that looks like
> >     card = kzalloc(sizeof(struct pio2_card), GFP_KERNEL);
> >   are changed to
> >     card = kzalloc(sizeof(*card), GFP_KERNEL);
> Also:
> 
>  * Removing extra bracketing from uses of the address operator
>  * Use preferred null return check style

Ick, not good, please break this up into individual patches,
one-per-type-of-fix.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] drivers: staging: vme: Fixed code style issues Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-11-25 00:30 +0100

csiph-web