Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1276816

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245

Show all headers | View raw

On Tue, Nov 24, 2015 at 5:49 PM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Mon, Nov 16, 2015 at 12:27:37PM +0800, Jiang Liu wrote:
>> From: Liu Jiang <jiang.liu@linux.intel.com>
>>
>> Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support
>> PCI host bridge") converted x86 to use the common interface
>> acpi_pci_root_create, but the conversion missed on code piece in
>> arch/x86/pci/bus_numa.c, which causes regression on some legacy
>> AMD platforms as reported by Arthur Marsh <arthur.marsh@internode.on.net>.
>> The root causes is that acpi_pci_root_create() fails to insert
>> host bridge resources into iomem_resource/ioport_resource because
>> x86_pci_root_bus_resources() has already inserted those resources.
>> So change x86_pci_root_bus_resources() to not insert resources into
>> iomem_resource/ioport_resource.
>
> Fixes: 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support PCI host bridge")
>
>> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
>> Reported-and-tested-by: Arthur Marsh <arthur.marsh@internode.on.net>
>
> What's the status of this?  It looks like a regression we need to fix
> for v4.4.
>
> AFAICT, Arthur did *not* test this patch (rather, his response says he
> did test it and the test failed).
>
> 4d6b4e69a245 was merged by Rafael, and I assume he'll merge the fix
> unless I hear otherwise.

Quite frankly, I'm more likely to revert the offending commit at this
point as that's not the only regression reported against it and the
fix only helps in one case (out of three known to me).

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245 Bjorn Helgaas <helgaas@kernel.org> - 2015-11-24 17:50 +0100
  Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245 "Rafael J. Wysocki" <rafael@kernel.org> - 2015-11-24 23:20 +0100
    Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245 Keith Busch <keith.busch@intel.com> - 2015-11-25 00:10 +0100
      Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245 Arthur Marsh <arthur.marsh@internode.on.net> - 2015-11-25 01:40 +0100
        Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245 Jiang Liu <jiang.liu@linux.intel.com> - 2015-11-25 09:30 +0100
          Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245 Arthur Marsh <arthur.marsh@internode.on.net> - 2015-11-25 11:20 +0100
    Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245 Jiang Liu <jiang.liu@linux.intel.com> - 2015-11-25 09:20 +0100
      Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245 "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> - 2015-11-25 14:20 +0100
        [PATCH] x86/PCI: Fix regression caused by commit 4d6b4e69a245 Jiang Liu <jiang.liu@linux.intel.com> - 2015-11-27 04:10 +0100
          Re: [PATCH] x86/PCI: Fix regression caused by commit 4d6b4e69a245 "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-11-27 16:40 +0100
            Re: [PATCH] x86/PCI: Fix regression caused by commit 4d6b4e69a245 Jiang Liu <jiang.liu@linux.intel.com> - 2015-11-30 02:30 +0100
              Re: [PATCH] x86/PCI: Fix regression caused by commit 4d6b4e69a245 "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-11-30 02:50 +0100

csiph-web