Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1276760
| From | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v5 1/8] watchdog: Introduce hardware maximum timeout in watchdog core |
| Date | 2015-11-24 22:20 +0100 |
| Message-ID | <qytaj-52D-11@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <qxPZg-4Er-13@gated-at.bofh.it> <qyg3n-4Yt-3@gated-at.bofh.it> <qynoe-1lP-33@gated-at.bofh.it> <qyotX-21n-17@gated-at.bofh.it> <qyoX0-2d3-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello Guenter,
On Tue, Nov 24, 2015 at 08:45:05AM -0800, Guenter Roeck wrote:
> On 11/24/2015 08:11 AM, Uwe Kleine-König wrote:
> >On Tue, Nov 24, 2015 at 07:03:13AM -0800, Guenter Roeck wrote:
> >>thanks a lot for the Ack. I have v6 in the works, which changes recording
> >>of last_keepalive when the watchdog is started. Does your Ack include that
> >>change, or do you prefer to have another look ?
> >
> >this change is to sample jiffies before .start is called as I suggested,
> >right? For that change keeping my ack is ok of course.
> >
>
> Correct. This is how the code now looks like.
>
> started_at = jiffies;
> if (watchdog_hw_running(wdd) && wdd->ops->ping)
> err = wdd->ops->ping(wdd);
> else
> err = wdd->ops->start(wdd);
> if (err == 0) {
> set_bit(WDOG_ACTIVE, &wdd->status);
> wdd->last_keepalive = started_at;
> watchdog_update_worker(wdd);
> }
\o/
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v5 0/8] watchdog: Add support for keepalives triggered by infrastructure Guenter Roeck <linux@roeck-us.net> - 2015-11-23 04:30 +0100
[PATCH v5 3/8] watchdog: Make set_timeout function optional Guenter Roeck <linux@roeck-us.net> - 2015-11-23 04:30 +0100
[PATCH v5 5/8] watchdog: Simplify update_worker Guenter Roeck <linux@roeck-us.net> - 2015-11-23 04:30 +0100
Re: [PATCH v5 5/8] watchdog: Simplify update_worker Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2015-11-24 08:20 +0100
Re: [PATCH v5 5/8] watchdog: Simplify update_worker Guenter Roeck <linux@roeck-us.net> - 2015-11-24 08:30 +0100
[PATCH v5 2/8] watchdog: Introduce WDOG_RUNNING flag Guenter Roeck <linux@roeck-us.net> - 2015-11-23 04:30 +0100
Re: [PATCH v5 2/8] watchdog: Introduce WDOG_RUNNING flag Alexander Stein <alexander.stein@systec-electronic.com> - 2015-11-23 17:40 +0100
Re: [PATCH v5 2/8] watchdog: Introduce WDOG_RUNNING flag Guenter Roeck <linux@roeck-us.net> - 2015-11-23 17:50 +0100
Re: [PATCH v5 2/8] watchdog: Introduce WDOG_RUNNING flag Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2015-11-23 20:30 +0100
Re: [PATCH v5 2/8] watchdog: Introduce WDOG_RUNNING flag Guenter Roeck <linux@roeck-us.net> - 2015-11-23 22:50 +0100
[RFT PATCH v5 8/8] watchdog: at91sam9: Convert to use infrastructure triggered keepalives Guenter Roeck <linux@roeck-us.net> - 2015-11-23 04:30 +0100
[PATCH v5 4/8] watchdog: Add support for minimum time between heartbeats Guenter Roeck <linux@roeck-us.net> - 2015-11-23 04:30 +0100
[PATCH v5 1/8] watchdog: Introduce hardware maximum timeout in watchdog core Guenter Roeck <linux@roeck-us.net> - 2015-11-23 04:30 +0100
Re: [PATCH v5 1/8] watchdog: Introduce hardware maximum timeout in watchdog core Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2015-11-23 09:00 +0100
Re: [PATCH v5 1/8] watchdog: Introduce hardware maximum timeout in watchdog core Guenter Roeck <linux@roeck-us.net> - 2015-11-23 17:20 +0100
Re: [PATCH v5 1/8] watchdog: Introduce hardware maximum timeout in watchdog core Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2015-11-23 19:30 +0100
Re: [PATCH v5 1/8] watchdog: Introduce hardware maximum timeout in watchdog core Guenter Roeck <linux@roeck-us.net> - 2015-11-23 23:00 +0100
Re: [PATCH v5 1/8] watchdog: Introduce hardware maximum timeout in watchdog core Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2015-11-24 08:20 +0100
Re: [PATCH v5 1/8] watchdog: Introduce hardware maximum timeout in watchdog core Guenter Roeck <linux@roeck-us.net> - 2015-11-24 16:10 +0100
Re: [PATCH v5 1/8] watchdog: Introduce hardware maximum timeout in watchdog core Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2015-11-24 17:20 +0100
Re: [PATCH v5 1/8] watchdog: Introduce hardware maximum timeout in watchdog core Guenter Roeck <linux@roeck-us.net> - 2015-11-24 17:50 +0100
Re: [PATCH v5 1/8] watchdog: Introduce hardware maximum timeout in watchdog core Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2015-11-24 22:20 +0100
csiph-web