Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1276777

Re: [PATCH net] ipv6: distinguish frag queues by device for multicast and link-local packets

Show all headers | View raw

From: Michal Kubecek <mkubecek@suse.cz>
Date: Tue, 24 Nov 2015 15:07:11 +0100 (CET)

> If a fragmented multicast packet is received on an ethernet device which
> has an active macvlan on top of it, each fragment is duplicated and
> received both on the underlying device and the macvlan. If some
> fragments for macvlan are processed before the whole packet for the
> underlying device is reassembled, the "overlapping fragments" test in
> ip6_frag_queue() discards the whole fragment queue.
> 
> To resolve this, add device ifindex to the search key and require it to
> match reassembling multicast packets and packets to link-local
> addresses.
> 
> Note: similar patch has been already submitted by Yoshifuji Hideaki in
> 
>   http://patchwork.ozlabs.org/patch/220979/
> 
> but got lost and forgotten for some reason.
> 
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>

This is definitely the right thing to do and matches how ipv4 keys
fragments.

Applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net] ipv6: distinguish frag queues by device for multicast and  link-local packets Michal Kubecek <mkubecek@suse.cz> - 2015-11-24 15:10 +0100
  Re: [PATCH net] ipv6: distinguish frag queues by device for  multicast and link-local packets David Miller <davem@davemloft.net> - 2015-11-24 22:50 +0100
    Re: [PATCH net] ipv6: distinguish frag queues by device for multicast  and link-local packets Hannes Frederic Sowa <hannes@stressinduktion.org> - 2015-11-24 23:10 +0100

csiph-web