Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1276748

Re: [PATCH v3 09/22] kthread: Allow to cancel kthread work

Show all headers | View raw

Hello,

On Tue, Nov 24, 2015 at 12:23:53PM -0800, Linus Torvalds wrote:
> instead (possibly just "spin_unlock_wait()" - but the explicit loop

I see.  Wasn't thinking about cache traffic.  Yeah, spin_unlock_wait()
seems a lot better.

> might be worth it if you then want to check the "canceling" flag
> independently of the lock state too).
> 
> In general, it's very dangerous to try to cook up your own locking
> rules. People *always* get it wrong.

It's either trylock on timer side or timer active spinning trick on
canceling side, so this seems the lesser of the two evils.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/22] kthread: Use kthread worker API more widely Petr Mladek <pmladek@suse.com> - 2015-11-18 14:30 +0100
  [PATCH v3 22/22] thermal/intel_powerclamp: Convert the kthread to kthread worker API Petr Mladek <pmladek@suse.com> - 2015-11-18 14:30 +0100
  [PATCH v3 06/22] kthread: Add destroy_kthread_worker() Petr Mladek <pmladek@suse.com> - 2015-11-18 14:30 +0100
  [PATCH v3 20/22] memstick/r592: convert r592_io kthread into kthread worker API Petr Mladek <pmladek@suse.com> - 2015-11-18 14:30 +0100
  [PATCH v3 18/22] IB/fmr_pool: Convert the cleanup thread into kthread worker API Petr Mladek <pmladek@suse.com> - 2015-11-18 14:30 +0100
    Re: [PATCH v3 18/22] IB/fmr_pool: Convert the cleanup thread into  kthread worker API Yuval Shaia <yuval.shaia@oracle.com> - 2015-11-19 13:50 +0100
  [PATCH v3 10/22] kthread: Allow to modify delayed kthread work Petr Mladek <pmladek@suse.com> - 2015-11-18 14:30 +0100
  [PATCH v3 11/22] kthread: Better support freezable kthread workers Petr Mladek <pmladek@suse.com> - 2015-11-18 14:30 +0100
  [PATCH v3 08/22] kthread: Initial support for delayed kthread work Petr Mladek <pmladek@suse.com> - 2015-11-18 14:40 +0100
  [PATCH v3 12/22] kthread: Use try_lock_kthread_work() in flush_kthread_work() Petr Mladek <pmladek@suse.com> - 2015-11-18 14:40 +0100
  [PATCH v3 05/22] kthread: Add drain_kthread_worker() Petr Mladek <pmladek@suse.com> - 2015-11-18 14:40 +0100
  [PATCH v3 13/22] mm/huge_page: Convert khugepaged() into kthread worker API Petr Mladek <pmladek@suse.com> - 2015-11-18 14:40 +0100
  [PATCH v3 09/22] kthread: Allow to cancel kthread work Petr Mladek <pmladek@suse.com> - 2015-11-18 14:40 +0100
    Re: [PATCH v3 09/22] kthread: Allow to cancel kthread work Tejun Heo <tj@kernel.org> - 2015-11-24 00:00 +0100
      Re: [PATCH v3 09/22] kthread: Allow to cancel kthread work Petr Mladek <pmladek@suse.com> - 2015-11-24 11:30 +0100
      Re: [PATCH v3 09/22] kthread: Allow to cancel kthread work Tejun Heo <tj@kernel.org> - 2015-11-24 21:30 +0100
        Re: [PATCH v3 09/22] kthread: Allow to cancel kthread work Linus Torvalds <torvalds@linux-foundation.org> - 2015-11-24 21:50 +0100
      Re: [PATCH v3 09/22] kthread: Allow to cancel kthread work Linus Torvalds <torvalds@linux-foundation.org> - 2015-11-24 21:30 +0100
  [PATCH v3 04/22] kthread: Add create_kthread_worker*() Petr Mladek <pmladek@suse.com> - 2015-11-18 14:40 +0100
  Re: [PATCH v3 00/22] kthread: Use kthread worker API more widely "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2015-11-18 15:30 +0100

csiph-web