Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1276659

Re: [PATCH] net/ipv4/ipconfig: Rejoin broken lines in console output

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] net/ipv4/ipconfig: Rejoin broken lines in console output
Date 2015-11-24 18:10 +0100
Message-ID <qypgm-2AY-11@gated-at.bofh.it> (permalink)
References <qylw7-5A-43@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: Tue, 24 Nov 2015 14:08:23 +0100

> Commit 09605cc12c078306 ("net ipv4: use preferred log methods") replaced
> a few calls of pr_cont() after a console print without a trailing
> newline by pr_info(), causing lines to be split during IP
> autoconfiguration, like:
> 
>     .
>     ,
>      OK
>     IP-Config: Got DHCP answer from 192.168.97.254,
>     my address is 192.168.97.44
> 
> Convert these back to using pr_cont(), so it prints again:
> 
>     ., OK
>     IP-Config: Got DHCP answer from 192.168.97.254, my address is 192.168.97.44
> 
> Absorb the printing of "my address ..." into the previous call to
> pr_info(), as there's no reason to use a continuation there.
> 
> Convert one more pr_info() to print nameservers while we're at it.
> 
> Fixes: 09605cc12c078306 ("net ipv4: use preferred log methods")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] net/ipv4/ipconfig: Rejoin broken lines in console output Geert Uytterhoeven <geert+renesas@glider.be> - 2015-11-24 14:10 +0100
  Re: [PATCH] net/ipv4/ipconfig: Rejoin broken lines in console  output David Miller <davem@davemloft.net> - 2015-11-24 18:10 +0100
  Re: [PATCH] net/ipv4/ipconfig: Rejoin broken lines in console output Joe Perches <joe@perches.com> - 2015-11-24 18:50 +0100

csiph-web