Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1276614

RE: [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head room in the skb

Show all headers | View raw

> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com]
> Sent: Tuesday, November 24, 2015 12:56 AM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: davem@davemloft.net; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; jasowang@redhat.com
> Subject: Re: [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head
> room in the skb
> 
> "K. Y. Srinivasan" <kys@microsoft.com> writes:
> 
> > The rndis header is 116 bytes big and can be placed in the default
> > head room that will be available in the skb.
> 
> We have the following in include/linux/netdevice.h:
> 
> #if defined(CONFIG_WLAN) || IS_ENABLED(CONFIG_AX25)
> # if defined(CONFIG_MAC80211_MESH)
> #  define LL_MAX_HEADER 128
> # else
> #  define LL_MAX_HEADER 96
> # endif
> #else
> # define LL_MAX_HEADER 32
> #endif
> 
> In case someone disables MAC80211_MESH in his kernel config we're in
> troubles again. I suggest we add additional patch here making sure it is
> 128 bytes for Hyper-V:
> 
> #if defined(CONFIG_HYPERV_NET)
> # define LL_MAX_HEADER 128
> #elseif defined(CONFIG_WLAN) || IS_ENABLED(CONFIG_AX25)
> ...

Thanks Vitaly; will do.

K. Y
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 00/10] hv_netvsc: Eliminate the additional head room  "K. Y. Srinivasan" <kys@microsoft.com> - 2015-11-23 23:00 +0100
  [PATCH net-next 02/10] hv_netvsc: Rearrange the hv_negtvsc_packet to be space efficient "K. Y. Srinivasan" <kys@microsoft.com> - 2015-11-23 23:00 +0100
  [PATCH net-next 01/10] hv_netvsc: Resize some of the variables in hv_netvsc_packet "K. Y. Srinivasan" <kys@microsoft.com> - 2015-11-23 23:00 +0100
    [PATCH net-next 06/10] hv_netvsc: Eliminate send_completion from struct hv_netvsc_packet "K. Y. Srinivasan" <kys@microsoft.com> - 2015-11-23 23:00 +0100
    [PATCH net-next 10/10] hv_netvsc: remove locking in netvsc_send() "K. Y. Srinivasan" <kys@microsoft.com> - 2015-11-23 23:00 +0100
    [PATCH net-next 07/10] hv_netvsc: Eliminate send_completion_ctx from struct hv_netvsc_packet "K. Y. Srinivasan" <kys@microsoft.com> - 2015-11-23 23:00 +0100
    [PATCH net-next 05/10] hv_netvsc: Eliminatte the data field from struct hv_netvsc_packet "K. Y. Srinivasan" <kys@microsoft.com> - 2015-11-23 23:00 +0100
    [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head room in the skb "K. Y. Srinivasan" <kys@microsoft.com> - 2015-11-23 23:10 +0100
      Re: [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head room in the skb Vitaly Kuznetsov <vkuznets@redhat.com> - 2015-11-24 10:00 +0100
        RE: [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head  room in the skb KY Srinivasan <kys@microsoft.com> - 2015-11-24 17:30 +0100
      Re: [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head  room in the skb Florian Westphal <fw@strlen.de> - 2015-11-24 10:00 +0100
        RE: [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head  room in the skb KY Srinivasan <kys@microsoft.com> - 2015-11-24 17:50 +0100
    [PATCH net-next 03/10] hv_netvsc: Eliminate the channel field in hv_netvsc_packet structure "K. Y. Srinivasan" <kys@microsoft.com> - 2015-11-23 23:10 +0100
    [PATCH net-next 04/10] hv_netvsc: Eliminate rndis_msg pointer from hv_netvsc_packet structure "K. Y. Srinivasan" <kys@microsoft.com> - 2015-11-23 23:10 +0100
    Re: [PATCH net-next 01/10] hv_netvsc: Resize some of the variables in hv_netvsc_packet Vitaly Kuznetsov <vkuznets@redhat.com> - 2015-11-24 09:50 +0100
      RE: [PATCH net-next 01/10] hv_netvsc: Resize some of the variables in  hv_netvsc_packet KY Srinivasan <kys@microsoft.com> - 2015-11-24 17:50 +0100

csiph-web