Re: [PATCH 1/2] block-rbd: Delete an unnecessary check before the function call "rbd_dev_destroy"

From	Ilya Dryomov <idryomov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] block-rbd: Delete an unnecessary check before the function call "rbd_dev_destroy"
Date	2015-11-24 14:30 +0100
Message-ID	<qylPs-cQ-7@gated-at.bofh.it> (permalink)
References	(14 earlier) <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <qy5hE-6fV-7@gated-at.bofh.it> <qy5hE-6fV-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 23, 2015 at 8:44 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 23 Nov 2015 20:16:45 +0100
>
> The rbd_dev_destroy() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/block/rbd.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 235708c..24a757e 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -5184,8 +5184,7 @@ static int rbd_dev_probe_parent(struct rbd_device *rbd_dev, int depth)
>
>  out_err:
>         rbd_dev_unparent(rbd_dev);
> -       if (parent)
> -               rbd_dev_destroy(parent);
> +       rbd_dev_destroy(parent);
>         return ret;
>  }

Applied, see https://github.com/ceph/ceph-client/commit/b0098c3eadd33fa212987dab0529e35c948aaff4.

Thanks,

                Ilya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/2] block-rbd: Deletion of an unnecessary check SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-23 20:50 +0100
  [PATCH 1/2] block-rbd: Delete an unnecessary check before the  function call "rbd_dev_destroy" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-23 20:50 +0100
    Re: [PATCH 1/2] block-rbd: Delete an unnecessary check before the  function call "rbd_dev_destroy" Ilya Dryomov <idryomov@gmail.com> - 2015-11-24 14:30 +0100
  [PATCH 2/2] block-rbd: One function call less in  rbd_dev_probe_parent() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-23 20:50 +0100
    Re: [PATCH 2/2] block-rbd: One function call less in  rbd_dev_probe_parent() after error detection Ilya Dryomov <idryomov@gmail.com> - 2015-11-24 14:30 +0100
      Re: [PATCH 2/2] block-rbd: One function call less in  rbd_dev_probe_parent() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-24 20:30 +0100
        Re: [PATCH 2/2] block-rbd: One function call less in  rbd_dev_probe_parent() after error detection Ilya Dryomov <idryomov@gmail.com> - 2015-11-24 21:30 +0100
          Re: block-rbd: One function call less in rbd_dev_probe_parent() after  error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-24 21:40 +0100
            Re: block-rbd: One function call less in rbd_dev_probe_parent() after  error detection Ilya Dryomov <idryomov@gmail.com> - 2015-11-24 23:00 +0100
              Re: block-rbd: One function call less in rbd_dev_probe_parent() after  error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-25 11:30 +0100
          Re: [PATCH 2/2] block-rbd: One function call less in  rbd_dev_probe_parent() after error detection Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-25 13:00 +0100
            Re: [PATCH 2/2] block-rbd: One function call less in  rbd_dev_probe_parent() after error detection Ilya Dryomov <idryomov@gmail.com> - 2015-11-25 15:10 +0100
              Re: [PATCH 2/2] block-rbd: One function call less in  rbd_dev_probe_parent() after error detection Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-25 16:30 +0100
          Re: block-rbd: One function call less in rbd_dev_probe_parent() after  error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-26 09:00 +0100
            Re: block-rbd: One function call less in rbd_dev_probe_parent() after  error detection Ilya Dryomov <idryomov@gmail.com> - 2015-11-26 12:50 +0100
              Re: block-rbd: One function call less in rbd_dev_probe_parent() after  error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-26 14:50 +0100

csiph-web