Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1276257

[tip:ras/core] x86/mce: Add the missing memory error check on AMD

Show all headers | View raw

Commit-ID:  db548a28fcee0f38cf4c7c726becf24c8afacf02
Gitweb:     http://git.kernel.org/tip/db548a28fcee0f38cf4c7c726becf24c8afacf02
Author:     Borislav Petkov <bp@suse.de>
AuthorDate: Tue, 24 Nov 2015 08:41:19 +0100
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 24 Nov 2015 09:12:35 +0100

x86/mce: Add the missing memory error check on AMD

We simply need to look at the extended error code when detecting
whether the error is of type memory.

Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Tony Luck <tony.luck@intel.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1448350880-5573-4-git-send-email-bp@alien8.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/cpu/mcheck/mce.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index fb8b1db..e00e85a 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -522,10 +522,10 @@ static bool memory_error(struct mce *m)
 	struct cpuinfo_x86 *c = &boot_cpu_data;
 
 	if (c->x86_vendor == X86_VENDOR_AMD) {
-		/*
-		 * coming soon
-		 */
-		return false;
+		/* ErrCodeExt[20:16] */
+		u8 xec = (m->status >> 16) & 0x1f;
+
+		return (xec == 0x0 || xec == 0x8);
 	} else if (c->x86_vendor == X86_VENDOR_INTEL) {
 		/*
 		 * Intel SDM Volume 3B - 15.9.2 Compound Error Codes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] RAS stuff for tip:x86/ras Borislav Petkov <bp@alien8.de> - 2015-11-24 08:50 +0100
  [PATCH 1/4] x86/mce: Do not enter deferred errors into the generic pool twice Borislav Petkov <bp@alien8.de> - 2015-11-24 08:50 +0100
    [tip:ras/core] x86/mce:   Do not enter deferred errors into the generic pool twice tip-bot for Tony Luck <tipbot@zytor.com> - 2015-11-24 10:40 +0100
  [PATCH 3/4] x86/mce: Add the missing memory error check on AMD Borislav Petkov <bp@alien8.de> - 2015-11-24 08:50 +0100
    [tip:ras/core] x86/mce: Add the missing memory error check on AMD tip-bot for Borislav Petkov <tipbot@zytor.com> - 2015-11-24 11:00 +0100
  [PATCH 2/4] x86/RAS: Remove mce.usable_addr Borislav Petkov <bp@alien8.de> - 2015-11-24 08:50 +0100
    [tip:ras/core] x86/RAS: Remove mce.usable_addr tip-bot for Borislav Petkov <tipbot@zytor.com> - 2015-11-24 10:40 +0100

csiph-web