[PATCH] Input: smtpe-ts: better way of using of_property_read_u32()

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Saurabh Sengar <saurabh.truth@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] Input: smtpe-ts: better way of using of_property_read_u32()
Date	Tue, 24 Nov 2015 08:10:01 +0100
Message-ID	<qyfTH-4UT-9@gated-at.bofh.it> (permalink)
X-Original-To	dmitry.torokhov@gmail.com, marex@denx.de, viresh.kumar@linaro.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=/tJdkOf6AqM9JoMGsjeVampbDtv6ihLilLrxJDRYPS8=; b=YzMlLfvZdDQTQ3x1w4MiASEJlCE5jWbOP5prRHLZLTn+/BFF+s8LLxMh2mSIQMeEOw j0kAp6GW0xoHrhPCqck6m5K1w30D6QzCuQh6wEy0EwwQ80eeOlSfv7izjrf8ye81y0TB b9+Hx8SRbIFfY2iQZaCCCk5OobvyIHgUAET2w4YaOMMGyWRk8DhY3Sz+c86seRKNGkg4 xzI1vC8WO22IFXu7AT1KVitcJhfQw98zv/rOKoBOaAQyZPVl+MTmbPwTKpmyOg0/m7S4 BslhRFgYT6o6tvPgQRMwtHzBf8pY46jaPID3HQnnv0wOZ6OZjOOkF3jJOPHf38HyTxR5 5CIw==
X-Received	by 10.68.106.131 with SMTP id gu3mr40628148pbb.9.1448348815527; Mon, 23 Nov 2015 23:06:55 -0800 (PST)
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	58
Organization	linux.* mail to news gateway
X-Original-Cc	Saurabh Sengar <saurabh.truth@gmail.com>
X-Original-Date	Tue, 24 Nov 2015 12:36:38 +0530
X-Original-Message-ID	<1448348798-5950-1-git-send-email-saurabh.truth@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1276095

Show key headers only | View raw

better way of using of_property_read_u32(), helps remove one variable
and many 'if' conditions

Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
---
 drivers/input/touchscreen/stmpe-ts.c | 29 ++++++++++-------------------
 1 file changed, 10 insertions(+), 19 deletions(-)

diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
index e414d43..51abe62 100644
--- a/drivers/input/touchscreen/stmpe-ts.c
+++ b/drivers/input/touchscreen/stmpe-ts.c
@@ -268,27 +268,18 @@ static void stmpe_ts_get_platform_info(struct platform_device *pdev,
 					struct stmpe_touch *ts)
 {
 	struct device_node *np = pdev->dev.of_node;
-	u32 val;
 
 	if (np) {
-		if (!of_property_read_u32(np, "st,sample-time", &val))
-			ts->sample_time = val;
-		if (!of_property_read_u32(np, "st,mod-12b", &val))
-			ts->mod_12b = val;
-		if (!of_property_read_u32(np, "st,ref-sel", &val))
-			ts->ref_sel = val;
-		if (!of_property_read_u32(np, "st,adc-freq", &val))
-			ts->adc_freq = val;
-		if (!of_property_read_u32(np, "st,ave-ctrl", &val))
-			ts->ave_ctrl = val;
-		if (!of_property_read_u32(np, "st,touch-det-delay", &val))
-			ts->touch_det_delay = val;
-		if (!of_property_read_u32(np, "st,settling", &val))
-			ts->settling = val;
-		if (!of_property_read_u32(np, "st,fraction-z", &val))
-			ts->fraction_z = val;
-		if (!of_property_read_u32(np, "st,i-drive", &val))
-			ts->i_drive = val;
+		of_property_read_u32(np, "st,sample-time", &ts->sample_time);
+		of_property_read_u32(np, "st,mod-12b", &ts->mod_12b);
+		of_property_read_u32(np, "st,ref-sel", &ts->ref_sel);
+		of_property_read_u32(np, "st,adc-freq", &ts->adc_freq);
+		of_property_read_u32(np, "st,ave-ctrl", &ts->ave_ctrl);
+		of_property_read_u32(np, "st,touch-det-delay",
+						&ts->touch_det_delay);
+		of_property_read_u32(np, "st,settling", &ts->settling = val);
+		of_property_read_u32(np, "st,fraction-z", &ts->fraction_z);
+		of_property_read_u32(np, "st,i-drive", &ts->i_drive);
 	}
 }
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] Input: smtpe-ts: better way of using of_property_read_u32() Saurabh Sengar <saurabh.truth@gmail.com> - 2015-11-24 08:10 +0100
  Re: [PATCH] Input: smtpe-ts: better way of using  of_property_read_u32() Viresh Kumar <viresh.kumar@linaro.org> - 2015-11-24 08:20 +0100

csiph-web