Re: [PATCH 2/3] zram: try vmalloc() after kmalloc()

From	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] zram: try vmalloc() after kmalloc()
Date	2015-11-24 07:20 +0100
Message-ID	<qyf7k-4lL-3@gated-at.bofh.it> (permalink)
References	<qyd5v-33y-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[..]
>  static void *zcomp_lz4_create(void)
>  {
> -       return kzalloc(LZ4_MEM_COMPRESS, GFP_KERNEL);
> +       void *ret;
> +
> +       /*
> +        * This function could be called in swapout/fs write path
> +        * so we couldn't use GFP_FS|IO. And it assumes we already
> +        * have at least one stream in zram initialization so we
> +        * don't do best effort to allocate more stream in here.
> +        * A default stream will work well without further multiple
> +        * stream. That's why we use  __GFP_NORETRY|NOWARN|NOMEMALLOC.
> +        */
> +       ret = kzalloc(LZ4_MEM_COMPRESS,
> +                       __GFP_NORETRY|__GFP_NOWARN|__GFP_NOMEMALLOC);
> +       if (!ret)
> +               ret = __vmalloc(LZ4_MEM_COMPRESS,
> +                                       __GFP_NORETRY|__GFP_NOWARN|
> +                                       __GFP_NOMEMALLOC|__GFP_ZERO,
> +                                       PAGE_KERNEL);
> +       return ret;
>  }
[..]

so this change is still questionable. is there a real value in having
a vmalloc() fallback in the middle of allocations sequence:

	zstrm = kmalloc(sizeof(*zstrm), GFP_NOIO);
		^^^ ok, can fail here

	zstrm->zstrm->private = comp->backend->create();
				^^^ kzalloc() and vmalloc() fallback ??

	zstrm->buffer = (void *)__get_free_pages(GFP_NOIO | __GFP_ZERO, 1);
		^^^ can fail here again.

can you please comment on this?


and I'd prefer it to be a bit different -- use likely path first and
avoid an assignment in unlikely path.
... and add GFP_NOIO to both kzalloc() and __vmalloc().

and there is no __GFP_HIGHMEM in __vmalloc() call?

something like this:

---


	ret = kzalloc(LZ4_MEM_COMPRESS, GFP_NOIO | __GFP_NORETRY |
					__GFP_NOWARN | __GFP_NOMEMALLOC);
	if (ret)
		return ret;

	return __vmalloc(LZ4_MEM_COMPRESS,
			GFP_NOIO | __GFP_NOWARN | __GFP_HIGHMEM | __GFP_ZERO,
			PAGE_KERNEL);


	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/3] zram/zcomp: use GFP_NOIO to allocate streams Minchan Kim <minchan@kernel.org> - 2015-11-24 05:10 +0100
  [RFC 3/3] zram: pass gfp from zcomp frontend to backend Minchan Kim <minchan@kernel.org> - 2015-11-24 05:10 +0100
  [PATCH 2/3] zram: try vmalloc() after kmalloc() Minchan Kim <minchan@kernel.org> - 2015-11-24 05:10 +0100
  Re: [PATCH 1/3] zram/zcomp: use GFP_NOIO to allocate streams Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-24 07:00 +0100
    Re: [PATCH 1/3] zram/zcomp: use GFP_NOIO to allocate streams Minchan Kim <minchan@kernel.org> - 2015-11-24 08:20 +0100
  Re: [PATCH 2/3] zram: try vmalloc() after kmalloc() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-24 07:20 +0100
    Re: [PATCH 2/3] zram: try vmalloc() after kmalloc() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-24 07:50 +0100
      Re: [PATCH 2/3] zram: try vmalloc() after kmalloc() Minchan Kim <minchan@kernel.org> - 2015-11-24 08:10 +0100
    Re: [PATCH 2/3] zram: try vmalloc() after kmalloc() Minchan Kim <minchan@kernel.org> - 2015-11-24 08:10 +0100
      Re: [PATCH 2/3] zram: try vmalloc() after kmalloc() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-24 08:40 +0100
        Re: [PATCH 2/3] zram: try vmalloc() after kmalloc() Minchan Kim <minchan@kernel.org> - 2015-11-24 09:00 +0100
          Re: [PATCH 2/3] zram: try vmalloc() after kmalloc() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-24 09:10 +0100
            Re: [PATCH 2/3] zram: try vmalloc() after kmalloc() Minchan Kim <minchan@kernel.org> - 2015-11-24 09:20 +0100

csiph-web