Re: [PATCH v2] i2c: cadence: Move to sensible power management

From	Shubhrajyoti Datta <shubhrajyoti.datta@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] i2c: cadence: Move to sensible power management
Date	2015-11-24 05:30 +0100
Message-ID	<qydoS-3c2-15@gated-at.bofh.it> (permalink)
References	<qoWQi-1vA-5@gated-at.bofh.it> <qoWQi-1vA-7@gated-at.bofh.it> <qoWQi-1vA-3@gated-at.bofh.it> <qxgyu-5TQ-33@gated-at.bofh.it> <qy4lz-5FS-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Nov 24, 2015 at 12:17 AM, Sören Brinkmann
<soren.brinkmann@xilinx.com> wrote:
> On Sat, 2015-11-21 at 07:00PM +0530, Shubhrajyoti Datta wrote:
>> On Thu, Oct 29, 2015 at 8:27 PM, Shubhrajyoti Datta
>> <shubhrajyoti.datta@gmail.com> wrote:
>> > On Wed, Oct 28, 2015 at 9:48 PM, Sören Brinkmann
>> > <soren.brinkmann@xilinx.com> wrote:
>> >> Hi Shubhrajyoti,
>> >>
>> >>
>> >> On Wed, 2015-10-28 at 12:56PM +0530, Shubhrajyoti Datta wrote:
>> >>> Currently the clocks are enabled at probe and disabled at remove.
>> >>> Which keeps the clocks enabled even if no transaction is going on.
>> >>> This patch enables the clocks at the start of transfer and disables
>> >>> after it.
>> >>>
>> >>> Also adapts to runtime pm.
>> >>> Remove xi2c->suspended and use pm runtime status instead.
>> >>>
>> >>> converts dev pm to const to silence a checkpatch warning.
>> >>>
>> >>> Signed-off-by: Shubhrajyoti Datta <shubhraj@xilinx.com>
>> >>
>> >> To me, this looks all good. Just one small concern below.
>> >
>> > Thanks for the review.
>> Soren ,
>> Do are you ok with the change or do you want me to resend without the
>> suspended flag change.
>
> I'm always for removing code that is not needed. If things are tested
> and well and work without throwing any warnings I'm OK with it.

It should be also having a suspended book-keeping in the driver is not
needed the pm does that for us.

I will spilt the patch and resend.

Thanks,

>
>         Sören
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] i2c: cadence: Move to sensible power management Shubhrajyoti Datta <shubhrajyoti.datta@gmail.com> - 2015-11-21 14:40 +0100
  Re: [PATCH v2] i2c: cadence: Move to sensible power management Sören Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-23 19:50 +0100
    Re: [PATCH v2] i2c: cadence: Move to sensible power management Shubhrajyoti Datta <shubhrajyoti.datta@gmail.com> - 2015-11-24 05:30 +0100

csiph-web