Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1278032

Re: [PATCH v2] USB: serial: cp210x: Add tx_empty()

Show all headers | View raw

On Thu, Nov 26, 2015 at 08:35:12AM +0100, Johan Hovold wrote:
> On Wed, Nov 25, 2015 at 10:26:12PM +0200, Andy Shevchenko wrote:
> > On Wed, Nov 25, 2015 at 12:28 AM, Konstantin Shkolnyy
> > <konstantin.shkolnyy@gmail.com> wrote:
> > > Added tx_empty callback needed for generic wait-until-sent support.
> > > Without this function, when the port is closed usbserial can't know that
> > > there are still data in the chip's transmit FIFO. The chip gets disabled
> > > and untransmitted data lost. When the actual byte count is reported by
> > > tx-empty the close can be delayed until all data are sent.

> > Btw, can be count left uninitialized?
> 
> Yes, but that's not an issue. Clearly separating the success and errors
> paths as I suggested above would make that more obvious however.
> 
> I'll fix that up before applying.

Now applied, thanks.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] USB: serial: cp210x: Add tx_empty() Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-11-24 23:30 +0100
  Re: [PATCH v2] USB: serial: cp210x: Add tx_empty() Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-25 21:30 +0100
    Re: [PATCH v2] USB: serial: cp210x: Add tx_empty() Johan Hovold <johan@kernel.org> - 2015-11-26 08:40 +0100
      Re: [PATCH v2] USB: serial: cp210x: Add tx_empty() Johan Hovold <johan@kernel.org> - 2015-11-26 08:50 +0100
    Re: [PATCH v2] USB: serial: cp210x: Add tx_empty() Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2015-11-26 17:20 +0100

csiph-web