Re: [PATCH] target: xen-scsiback: Return proper -Exx instead of -1.

From	Juergen Gross <jgross@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] target: xen-scsiback: Return proper -Exx instead of -1.
Date	2015-11-26 07:40 +0100
Message-ID	<qyYnL-14m-9@gated-at.bofh.it> (permalink)
References	<qyNVn-22H-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 25/11/15 20:24, Konrad Rzeszutek Wilk wrote:
> We could return EINVAL but EBUSY (or EALREADY?)is more appropiate.
> 
> CC: jgross@suse.com
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

While it doesn't really matter it's cleaner.

Reviewed-by: Juergen Gross <jgross@suse.com>

> ---
>  drivers/xen/xen-scsiback.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c
> index 43bcae8..286e3da 100644
> --- a/drivers/xen/xen-scsiback.c
> +++ b/drivers/xen/xen-scsiback.c
> @@ -800,7 +800,7 @@ static int scsiback_init_sring(struct vscsibk_info *info, grant_ref_t ring_ref,
>  	int err;
>  
>  	if (info->irq)
> -		return -1;
> +		return -EBUSY;
>  
>  	err = xenbus_map_ring_valloc(info->dev, &ring_ref, 1, &area);
>  	if (err)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] target: xen-scsiback: Return proper -Exx instead of -1. Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2015-11-25 20:30 +0100
  Re: [PATCH] target: xen-scsiback: Return proper -Exx instead of -1. Juergen Gross <jgross@suse.com> - 2015-11-26 07:40 +0100

csiph-web