Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1277944

[for-next][PATCH 1/5] ring-buffer: Process commits whenever moving to a new page.

From Steven Rostedt <rostedt@goodmis.org>
Newsgroups linux.kernel
Subject [for-next][PATCH 1/5] ring-buffer: Process commits whenever moving to a new page.
Date 2015-11-26 03:30 +0100
Message-ID <qyUtQ-6iR-11@gated-at.bofh.it> (permalink)
References <qyUtQ-6iR-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>

When crossing over to a new page, commit the current work. This will allow
readers to get data with less latency, and also simplifies the work to get
timestamps working for interrupted events.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/trace/ring_buffer.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 631541a53baf..95181e36891a 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -2129,6 +2129,8 @@ rb_reset_tail(struct ring_buffer_per_cpu *cpu_buffer,
 	local_sub(length, &tail_page->write);
 }
 
+static inline void rb_end_commit(struct ring_buffer_per_cpu *cpu_buffer);
+
 /*
  * This is the slow path, force gcc not to inline it.
  */
@@ -2220,6 +2222,11 @@ rb_move_tail(struct ring_buffer_per_cpu *cpu_buffer,
 
 	rb_reset_tail(cpu_buffer, tail, info);
 
+	/* Commit what we have for now. */
+	rb_end_commit(cpu_buffer);
+	/* rb_end_commit() decs committing */
+	local_inc(&cpu_buffer->committing);
+
 	/* fail and let the caller try again */
 	return ERR_PTR(-EAGAIN);
 
-- 
2.6.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[for-next][PATCH 0/5] tracing: Better output when ftrace_bug() is hit Steven Rostedt <rostedt@goodmis.org> - 2015-11-26 03:30 +0100
  [for-next][PATCH 3/5] ftrace: Add new type to distinguish what kind of ftrace_bug() Steven Rostedt <rostedt@goodmis.org> - 2015-11-26 03:30 +0100
  [for-next][PATCH 1/5] ring-buffer: Process commits whenever moving to a new page. Steven Rostedt <rostedt@goodmis.org> - 2015-11-26 03:30 +0100
  [for-next][PATCH 4/5] ftrace: Add variable ftrace_expected for archs to show expected code Steven Rostedt <rostedt@goodmis.org> - 2015-11-26 03:30 +0100
  [for-next][PATCH 2/5] tracing: Update cond flag when enabling or disabling a trigger Steven Rostedt <rostedt@goodmis.org> - 2015-11-26 03:30 +0100

csiph-web