Re: [PATCH v3 02/22] kthread/smpboot: Do not park in kthread_create_on_cpu()

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 02/22] kthread/smpboot: Do not park in kthread_create_on_cpu()
Date	2015-11-25 22:20 +0100
Message-ID	<qyPDQ-3dq-9@gated-at.bofh.it> (permalink)
References	<qwaYa-3sP-5@gated-at.bofh.it> <qwaYa-3sP-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 18 Nov 2015, Petr Mladek wrote:
> kthread_create_on_cpu() was added by the commit 2a1d446019f9a5983e
> ("kthread: Implement park/unpark facility"). It is currently used
> only when enabling new CPU. For this purpose, the newly created
> kthread has to be parked.
> 
> The CPU binding is a bit tricky. The kthread is parked when the CPU
> has not been allowed yet. And the CPU is bound when the kthread
> is unparked.
> 
> The function would be useful for more per-CPU kthreads, e.g.
> bnx2fc_thread, fcoethread. For this purpose, the newly created
> kthread should stay in the uninterruptible state.
> 
> This patch moves the parking into smpboot. It binds the thread
> already when created. Then the function might be used universally.
> Also the behavior is consistent with kthread_create() and
> kthread_create_on_node().
> 
> Signed-off-by: Petr Mladek <pmladek@suse.com>

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 02/22] kthread/smpboot: Do not park in kthread_create_on_cpu() Petr Mladek <pmladek@suse.com> - 2015-11-18 14:30 +0100
  Re: [PATCH v3 02/22] kthread/smpboot: Do not park in  kthread_create_on_cpu() Thomas Gleixner <tglx@linutronix.de> - 2015-11-25 22:20 +0100

csiph-web