Re: [PATCH] drivers/rtc/rtc-tps65910.c: Add IRQF_ONESHOT to interrupt flags

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers/rtc/rtc-tps65910.c: Add IRQF_ONESHOT to interrupt flags
Date	2015-11-25 19:50 +0100
Message-ID	<qyNiF-1z2-5@gated-at.bofh.it> (permalink)
References	<qyMZk-1sg-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 25/11/2015 at 23:49:57 +0530, Saurabh Sengar wrote :
> If no primary handler is specified for threaded_irq then a
> default one is assigned which always returns IRQ_WAKE_THREAD.
> This handler requires the IRQF_ONESHOT, because the source of
> interrupt is not disabled
> 

Are you sure this is necessary? The parent irqchip is the mfd and it
sets IRQF_ONESHOT.

Does that solve a real problem or is it a false positive coming from a
static analysis tool?


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drivers/rtc/rtc-tps65910.c: Add IRQF_ONESHOT to interrupt flags Saurabh Sengar <saurabh.truth@gmail.com> - 2015-11-25 19:30 +0100
  Re: [PATCH] drivers/rtc/rtc-tps65910.c: Add IRQF_ONESHOT to  interrupt flags Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-11-25 19:50 +0100

csiph-web