Re: [PATCH 2/2] arm: boot: beaglex15: pass correct interrupt

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] arm: boot: beaglex15: pass correct interrupt
Date	2015-11-25 20:10 +0100
Message-ID	<qyNC2-1Wc-25@gated-at.bofh.it> (permalink)
References	<qu4k9-3yL-3@gated-at.bofh.it> <qu4ka-3yL-23@gated-at.bofh.it> <qwMAp-2XN-1@gated-at.bofh.it> <qwXcu-1li-29@gated-at.bofh.it> <qwXcu-1li-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Chanwoo Choi <cwchoi00@gmail.com> [151120 08:56]:
> Hi,
> 
> On Sat, Nov 21, 2015 at 1:42 AM, Chanwoo Choi <cwchoi00@gmail.com> wrote:
> > Hi,
> >
> > On 2015. 11. 20. 오후 2:39, Chanwoo Choi wrote:
> >> Hi,
> >>
> >> On 2015년 11월 13일 02:53, Felipe Balbi wrote:
> >>> According to latest schematics [1], GPIO_1/VBUSDET
> >>> on TPS659038 is tied to AM57x GPIO4_21. We can use
> >>> that as a VBUS interrupt, instead of relying on
> >>> PMIC's VBUS interrupts which don't seem to be firing
> >>> on x15 at all.
> >>>
> >>> A follow up patch will add support for using this
> >>> GPIO-based interrupt mechanism for notifying about
> >>> VBUS.
> >>>
> >>> [1] https://github.com/beagleboard/beagleboard-x15/blob/master/BeagleBoard-X15_RevA2.pdf
> >>>
> >>> Signed-off-by: Felipe Balbi <balbi@ti.com>
> >>> ---
> >>>  arch/arm/boot/dts/am57xx-beagle-x15.dts | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> >>> index 6f3a1a7ec5f9..5e47162f7883 100644
> >>> --- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
> >>> +++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> >>> @@ -560,6 +560,7 @@
> >>>              extcon_usb2: tps659038_usb {
> >>>                      compatible = "ti,palmas-usb-vid";
> >>>                      ti,enable-vbus-detection;
> >>> +                    interrupts-extended = <&gpio4 21 IRQ_TYPE_EDGE_RISING>;
> >
> >                         vbus-gpio = <&gpio4 21>;
> 
> I'm sorry. I'm sending the missing email without writing completion.
> 
> I agree the Felipe's opinion. Just I think that we can use the
> following property
> instead of 'interrupt-extended'. Because I think 'vbus-gpio' is more
> readability than before. The following property mean the attribute of
> GPIO pin as VBUS.
> - vbus-gpio = <&gpio4 21>;

Hmm OK not applying the first two patches yet then as it seems changes
are needed. Felipe can you please repost the missing ones after you guys
have figured out which dts changes are needed?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] arm: boot: beaglex15: pass correct interrupt Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-20 06:40 +0100
  Re: [PATCH 2/2] arm: boot: beaglex15: pass correct interrupt Chanwoo Choi <cwchoi00@gmail.com> - 2015-11-20 18:00 +0100
    Re: [PATCH 2/2] arm: boot: beaglex15: pass correct interrupt Tony Lindgren <tony@atomide.com> - 2015-11-25 20:10 +0100

csiph-web