Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1277676

Re: [PATCH 01/13] net: mvneta: add configuration for MBUS windows access protection

From Gregory CLEMENT <gregory.clement@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [PATCH 01/13] net: mvneta: add configuration for MBUS windows access protection
Date 2015-11-25 19:20 +0100
Message-ID <qyMPF-1oW-19@gated-at.bofh.it> (permalink)
References <qxxJ0-HM-3@gated-at.bofh.it> <qxxJ1-HM-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Marcin,
 
 On dim., nov. 22 2015, Marcin Wojtas <mw@semihalf.com> wrote:

> This commit adds missing configuration of MBUS windows access protection
> in mvneta_conf_mbus_windows function - a dedicated variable for that
> purpose remained there unused since v3.8 initial mvneta support. Because
> of that the register contents were inherited from the bootloader.

It looks OK for me and at least after applying the driver continues
working :)

I guess you find it when you tested suspend to ram.

Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory


>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> Cc: <stable@vger.kernel.org> # v3.8+
> ---
>  drivers/net/ethernet/marvell/mvneta.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> index e84c7f2..0f30aaa 100644
> --- a/drivers/net/ethernet/marvell/mvneta.c
> +++ b/drivers/net/ethernet/marvell/mvneta.c
> @@ -62,6 +62,7 @@
>  #define MVNETA_WIN_SIZE(w)                      (0x2204 + ((w) << 3))
>  #define MVNETA_WIN_REMAP(w)                     (0x2280 + ((w) << 2))
>  #define MVNETA_BASE_ADDR_ENABLE                 0x2290
> +#define MVNETA_ACCESS_PROTECT_ENABLE		0x2294
>  #define MVNETA_PORT_CONFIG                      0x2400
>  #define      MVNETA_UNI_PROMISC_MODE            BIT(0)
>  #define      MVNETA_DEF_RXQ(q)                  ((q) << 1)
> @@ -3188,6 +3189,8 @@ static void mvneta_conf_mbus_windows(struct mvneta_port *pp,
>  
>  		win_enable &= ~(1 << i);
>  		win_protect |= 3 << (2 * i);
> +
> +		mvreg_write(pp, MVNETA_ACCESS_PROTECT_ENABLE, win_protect);
>  	}
>  
>  	mvreg_write(pp, MVNETA_BASE_ADDR_ENABLE, win_enable);
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/13] mvneta Buffer Management and enhancements Marcin Wojtas <mw@semihalf.com> - 2015-11-22 09:00 +0100
  [PATCH 13/13] ARM: mvebu: enable buffer manager support on Armada XP boards Marcin Wojtas <mw@semihalf.com> - 2015-11-22 09:00 +0100
  [PATCH 04/13] net: mvneta: enable suspend/resume support Marcin Wojtas <mw@semihalf.com> - 2015-11-22 09:00 +0100
    Re: [PATCH 04/13] net: mvneta: enable suspend/resume support Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-11-25 19:40 +0100
      Re: [PATCH 04/13] net: mvneta: enable suspend/resume support Marcin Wojtas <mw@semihalf.com> - 2015-11-26 18:40 +0100
  [PATCH 12/13] ARM: mvebu: add buffer manager nodes to armada-xp.dtsi Marcin Wojtas <mw@semihalf.com> - 2015-11-22 09:00 +0100
  [PATCH 01/13] net: mvneta: add configuration for MBUS windows access protection Marcin Wojtas <mw@semihalf.com> - 2015-11-22 09:00 +0100
    Re: [PATCH 01/13] net: mvneta: add configuration for MBUS windows access protection Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-11-25 19:20 +0100
  [PATCH 11/13] ARM: mvebu: enable buffer manager support on Armada 38x boards Marcin Wojtas <mw@semihalf.com> - 2015-11-22 09:00 +0100
  [PATCH 07/13] bus: mvebu-mbus: provide api for obtaining IO and DRAM window information Marcin Wojtas <mw@semihalf.com> - 2015-11-22 09:00 +0100
    Re: [PATCH 07/13] bus: mvebu-mbus: provide api for obtaining IO and DRAM window information Arnd Bergmann <arnd@arndb.de> - 2015-11-22 21:10 +0100
      Re: [PATCH 07/13] bus: mvebu-mbus: provide api for obtaining IO and  DRAM window information Marcin Wojtas <mw@semihalf.com> - 2015-11-22 22:30 +0100
        Re: [PATCH 07/13] bus: mvebu-mbus: provide api for obtaining IO and DRAM window information Arnd Bergmann <arnd@arndb.de> - 2015-11-23 18:00 +0100
  Re: [PATCH 00/13] mvneta Buffer Management and enhancements Arnd Bergmann <arnd@arndb.de> - 2015-11-22 21:10 +0100
    Re: [PATCH 00/13] mvneta Buffer Management and enhancements Marcin Wojtas <mw@semihalf.com> - 2015-11-22 22:40 +0100
  Re: [PATCH 00/13] mvneta Buffer Management and enhancements David Miller <davem@davemloft.net> - 2015-11-24 17:30 +0100
    Re: [PATCH 00/13] mvneta Buffer Management and enhancements Marcin Wojtas <mw@semihalf.com> - 2015-11-24 17:50 +0100
  Re: [PATCH 00/13] mvneta Buffer Management and enhancements Florian Fainelli <f.fainelli@gmail.com> - 2015-11-25 19:40 +0100
    Re: [PATCH 00/13] mvneta Buffer Management and enhancements Marcin Wojtas <mw@semihalf.com> - 2015-11-29 14:30 +0100
      Re: [PATCH 00/13] mvneta Buffer Management and enhancements David Miller <davem@davemloft.net> - 2015-11-30 03:10 +0100
        Re: [PATCH 00/13] mvneta Buffer Management and enhancements Marcin Wojtas <mw@semihalf.com> - 2015-11-30 15:20 +0100

csiph-web