Re: [RFC PATCH 1/2] drm: add support for for clk and de polarity

Path	csiph.com!news.mixmin.net!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Philipp Zabel <p.zabel@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 1/2] drm: add support for for clk and de polarity
Date	Wed, 25 Nov 2015 18:30:04 +0100
Message-ID	<qyM3h-RQ-33@gated-at.bofh.it> (permalink)
References	<pMx6x-3K9-7@gated-at.bofh.it> <pMxgg-3VA-31@gated-at.bofh.it>
X-Original-To	Manfred Schlaegl <manfred.schlaegl@gmx.at>
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.12.9-1+b1
MIME-Version	1.0
Content-Transfer-Encoding	7bit
X-Sa-Exim-Connect-IP	2001:67c:670:100:96de:80ff:fec2:9969
X-Sa-Exim-Mail-From	p.zabel@pengutronix.de
X-Sa-Exim-Scanned	No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-Ptx-Original-Recipient	linux-kernel@vger.kernel.org
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
Organization	linux.* mail to news gateway
X-Original-Cc	David Airlie <airlied@linux.ie>, Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>, Tomi Valkeinen <tomi.valkeinen@ti.com>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Manfred Schlaegl <manfred.schlaegl@ginzinger.com>, Steve Longerbeam <slongerbeam@gmail.com>, Deepak Das <deepak_das@mentor.com>, Jiada Wang <jiada_wang@mentor.com>, linux-fbdev@vger.kernel.org
X-Original-Date	Wed, 25 Nov 2015 18:22:21 +0100
X-Original-Message-ID	<1448472141.3390.17.camel@pengutronix.de>
X-Original-References	<55A67FDB.8010602@gmx.at> <55A6813A.8090706@gmx.at>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1277635

Show key headers only | View raw

Am Mittwoch, den 15.07.2015, 17:50 +0200 schrieb Manfred Schlaegl:
> To get full support for parallel and LVDS displays with drm:
> Add representation for clock and data enable polarity in drm_display_mode
> flags (similar to HSYNC/VSYNC polarity) and update conversion functions
> from/to videomode accordingly.
> 
> This is especially important for embedded devices where parallel(RGB) and
> LVDS displays are still widely used and drm already plays an important
> role.
> 
> Tested on Freescale i.MX53(parallel) and i.MX6(LVDS).
> 
> Background:
> There was the ability to set polarity of clock and data enable signals
> in devicetree(display-timing), struct display_timing and struct videomode,
> but there was no representation for this in struct drm_display_mode.
> Example on Freescale i.MX53/i.MX6 SoC's:
>  * A parallel display using different clock polarity is set up using
>    display-timing in devicetree
>  * ipuv3 parallel outputs clock with wrong polarity
> 
> Signed-off-by: Manfred Schlaegl <manfred.schlaegl@gmx.at>

Any comments on whether data enable and pixel clock polarity flags can
be added to the visible DRM_MODE_FLAGs, and if not, where else this
information should be kept? struct drm_display_info?

This patch and the following IPUv3 patch are useful and necessary for
quite some panels connected to i.MX SoCs, but adding DRM_MODE_FLAGs is
somewhat out of my jurisdiction.

best regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 1/2] drm: add support for for clk and de polarity Philipp Zabel <p.zabel@pengutronix.de> - 2015-11-25 18:30 +0100
  Re: [RFC PATCH 1/2] drm: add support for for clk and de polarity Manfred Schlaegl <manfred.schlaegl@gmx.at> - 2015-11-26 15:30 +0100
    Re: [RFC PATCH 1/2] drm: add support for for clk and de polarity Tomi Valkeinen <tomi.valkeinen@ti.com> - 2015-11-27 08:40 +0100

csiph-web