Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1277552

Re: [PATCH] net: usb: ch9200: use kmemdup instead of kmalloc + memcpy

Show all headers | View raw

Anup Limbu <anuplimbu14@gmail.com> writes:

> replace kmalloc + memset with kmemdup
>
> Signed-off-by: Anup Limbu <anuplimbu14@gmail.com>
> ---
>  drivers/net/usb/ch9200.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/usb/ch9200.c b/drivers/net/usb/ch9200.c
> index 5e151e6..8a40202 100644
> --- a/drivers/net/usb/ch9200.c
> +++ b/drivers/net/usb/ch9200.c
> @@ -155,12 +155,11 @@ static int control_write(struct usbnet *dev, unsigned char request,
>  		   index, size);
>  
>  	if (data) {
> -		buf = kmalloc(size, GFP_KERNEL);
> +		buf = kmemdup(data, size, GFP_KERNEL);
>  		if (!buf) {
>  			err = -ENOMEM;
>  			goto err_out;
>  		}
> -		memcpy(buf, data, size);
>  	}
>  
>  	err = usb_control_msg(dev->udev,


Would it be better to replace control_read() and control_write() with
the usbnet_read_cmd() and usbnet_write_cmd() if you are going to clean
this up?



Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: usb: ch9200: use kmemdup instead of kmalloc + memcpy Anup Limbu <anuplimbu14@gmail.com> - 2015-11-25 11:10 +0100
  Re: [PATCH] net: usb: ch9200: use kmemdup instead of kmalloc + memcpy Bjørn Mork <bjorn@mork.no> - 2015-11-25 17:20 +0100
  Re: [PATCH] net: usb: ch9200: use kmemdup instead of kmalloc +  memcpy David Miller <davem@davemloft.net> - 2015-11-30 04:50 +0100

csiph-web