Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1277547

Re: KASAN failures in X-Gene ethernet driver in v4.4-rc2

From Eric Dumazet <eric.dumazet@gmail.com>
Newsgroups linux.kernel
Subject Re: KASAN failures in X-Gene ethernet driver in v4.4-rc2
Date 2015-11-25 17:20 +0100
Message-ID <qyKXx-cZ-13@gated-at.bofh.it> (permalink)
References <qyKEb-8h2-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, 2015-11-25 at 15:59 +0000, Mark Rutland wrote:
> xgene_enet_start_xmit

Please try following trivial fix

diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 1adfe7036843..9147a0107c44 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@ -450,12 +450,12 @@ static netdev_tx_t xgene_enet_start_xmit(struct sk_buff *skb,
 		return NETDEV_TX_OK;
 	}
 
-	pdata->ring_ops->wr_cmd(tx_ring, count);
 	skb_tx_timestamp(skb);
 
 	pdata->stats.tx_packets++;
 	pdata->stats.tx_bytes += skb->len;
 
+	pdata->ring_ops->wr_cmd(tx_ring, count);
 	return NETDEV_TX_OK;
 }
 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

KASAN failures in X-Gene ethernet driver in v4.4-rc2 Mark Rutland <mark.rutland@arm.com> - 2015-11-25 17:00 +0100
  Re: KASAN failures in X-Gene ethernet driver in v4.4-rc2 Eric Dumazet <eric.dumazet@gmail.com> - 2015-11-25 17:20 +0100
    Re: KASAN failures in X-Gene ethernet driver in v4.4-rc2 Mark Rutland <mark.rutland@arm.com> - 2015-11-25 17:40 +0100
      [PATCH net] drivers: net: xgene: fix possible use after free Eric Dumazet <eric.dumazet@gmail.com> - 2015-11-25 18:10 +0100
        Re: [PATCH net] drivers: net: xgene: fix possible use after free Iyappan Subramanian <isubramanian@apm.com> - 2015-11-28 04:40 +0100
        Re: [PATCH net] drivers: net: xgene: fix possible use after free David Miller <davem@davemloft.net> - 2015-11-30 05:00 +0100

csiph-web