Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1277242
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/2] ALSA: compress: Pass id string to snd_compress_new |
| Date | 2015-11-25 12:20 +0100 |
| Message-ID | <qyGhd-5xi-33@gated-at.bofh.it> (permalink) |
| References | <qyFO9-56R-15@gated-at.bofh.it> <qyFOa-56R-29@gated-at.bofh.it> <qyFOa-56R-27@gated-at.bofh.it> <qyG7x-5tK-43@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Wed, Nov 25, 2015 at 11:07:01AM +0000, Richard Fitzgerald wrote: > On Wed, 2015-11-25 at 11:49 +0100, Takashi Iwai wrote: > > > + if (IS_ENABLED(CONFIG_SND_VERBOSE_PROCFS)) > > This should be #if. Otherwise the compile would fail (as already > Builds ok for me, this will become if(false) if it's not enabled so the > compiler will strip it out - some maintainers prefer that to #if and I'm > used to being told to use this style instead of #if, so who knows what > today's coding style is :) The build bot failure was for a different > reason. The compiler will still spot syntax errors and similar in an if (false) section.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/2] ALSA: compress: Add procfs info file for compressed nodes Richard Fitzgerald <rf@opensource.wolfsonmicro.com> - 2015-11-25 11:50 +0100
Re: [PATCH v2 2/2] ALSA: compress: Pass id string to snd_compress_new Takashi Iwai <tiwai@suse.de> - 2015-11-25 11:50 +0100
Re: [PATCH v2 2/2] ALSA: compress: Pass id string to snd_compress_new Richard Fitzgerald <rf@opensource.wolfsonmicro.com> - 2015-11-25 12:10 +0100
Re: [PATCH v2 2/2] ALSA: compress: Pass id string to snd_compress_new Mark Brown <broonie@kernel.org> - 2015-11-25 12:20 +0100
Re: [PATCH v2 2/2] ALSA: compress: Pass id string to snd_compress_new Takashi Iwai <tiwai@suse.de> - 2015-11-25 12:30 +0100
[PATCH v2 2/2] ALSA: compress: Pass id string to snd_compress_new Richard Fitzgerald <rf@opensource.wolfsonmicro.com> - 2015-11-25 11:50 +0100
csiph-web