Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1277193

Re: [PATCH v2] mm/cma: always check which page cause allocation failure

Show all headers | View raw

On 11/25/2015 06:32 AM, Joonsoo Kim wrote:
> Now, we have tracepoint in test_pages_isolated() to notify
> pfn which cannot be isolated. But, in alloc_contig_range(),
> some error path doesn't call test_pages_isolated() so it's still
> hard to know exact pfn that causes allocation failure.
> 
> This patch change this situation by calling test_pages_isolated()
> in almost error path. In allocation failure case, some overhead
> is added by this change, but, allocation failure is really rare
> event so it would not matter.
> 
> In fatal signal pending case, we don't call test_pages_isolated()
> because this failure is intentional one.
> 
> There was a bogus outer_start problem due to unchecked buddy order
> and this patch also fix it. Before this patch, it didn't matter,
> because end result is same thing. But, after this patch,
> tracepoint will report failed pfn so it should be accurate.
> 
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/3] mm/cma: always check which page cause allocation  failure Vlastimil Babka <vbabka@suse.cz> - 2015-11-24 16:30 +0100
  Re: [PATCH 3/3] mm/cma: always check which page cause allocation  failure Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2015-11-25 03:40 +0100
    [PATCH v2] mm/cma: always check which page cause allocation failure Joonsoo Kim <js1304@gmail.com> - 2015-11-25 06:40 +0100
      Re: [PATCH v2] mm/cma: always check which page cause allocation  failure Vlastimil Babka <vbabka@suse.cz> - 2015-11-25 11:50 +0100

csiph-web