Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init cgroupns

From	"Serge E. Hallyn" <serge.hallyn@ubuntu.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init cgroupns
Date	2015-11-25 07:10 +0100
Message-ID	<qyBrb-2fY-1@gated-at.bofh.it> (permalink)
References	<qvy6u-3b3-3@gated-at.bofh.it> <qvy6t-3b3-1@gated-at.bofh.it> <qypq1-2Eg-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Nov 24, 2015 at 12:16:10PM -0500, Tejun Heo wrote:
...
> > +		if (ns != &init_cgroup_ns) {
> > +			struct dentry *nsdentry;
> > +			struct cgroup *cgrp;
> > +
> > +			cgrp = cset_cgroup_from_root(ns->root_cgrps, root);
> > +			nsdentry = kernfs_obtain_root(dentry->d_sb,
> > +				cgrp->kn);
> > +			dput(dentry);
> > +			dentry = nsdentry;
> > +		}
> > +	}
> 
> So, this would effectively allow namespace mounts to claim controllers
> which aren't configured otherwise which doesn't seem like a good idea.
> I think the right thing to do for namespace mounts is to always
> require an existing superblock.

that was my goal with https://git.kernel.org/cgit/linux/kernel/git/sergeh/linux-security.git/commit/?h=cgroupns.v4&id=8eb75d2bb24df59e262f050dce567d2332adc5f3
(which was sent inline earlier in this thread in response to Eric)  Does
that look sufficient?

thanks,
-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 7/8] cgroup: mount cgroupns-root when inside non-init cgroupns serge@hallyn.com - 2015-11-16 21:00 +0100
  Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init  cgroupns Tejun Heo <tj@kernel.org> - 2015-11-24 18:20 +0100
    Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init  cgroupns "Serge E. Hallyn" <serge.hallyn@ubuntu.com> - 2015-11-25 07:10 +0100
      Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init  cgroupns Tejun Heo <tj@kernel.org> - 2015-11-25 20:20 +0100
        Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init  cgroupns Tejun Heo <tj@kernel.org> - 2015-11-25 21:00 +0100
        Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init  cgroupns Serge Hallyn <serge.hallyn@ubuntu.com> - 2015-11-25 21:00 +0100
    Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init  cgroupns "Serge E. Hallyn" <serge.hallyn@ubuntu.com> - 2015-11-27 06:20 +0100
      Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init  cgroupns Tejun Heo <tj@kernel.org> - 2015-11-30 16:10 +0100

csiph-web