Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1277028

Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver

Show all headers | View raw

On Tue, Nov 24, 2015 at 1:20 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Tue, Nov 24, 2015 at 09:38:18PM +0800, Lan Tianyu wrote:
>> This patch is to add migration support for ixgbevf driver. Using
>> faked PCI migration capability table communicates with Qemu to
>> share migration status and mailbox irq vector index.
>>
>> Qemu will notify VF via sending MSIX msg to trigger mailbox
>> vector during migration and store migration status in the
>> PCI_VF_MIGRATION_VMM_STATUS regs in the new capability table.
>> The mailbox irq will be triggered just befoe stop-and-copy stage
>> and after migration on the target machine.
>>
>> VF driver will put down net when detect migration and tell
>> Qemu it's ready for migration via writing PCI_VF_MIGRATION_VF_STATUS
>> reg. After migration, put up net again.
>>
>> Qemu will in charge of migrating PCI config space regs and MSIX config.
>>
>> The patch is to dedicate on the normal case that net traffic works
>> when mailbox irq is enabled. For other cases(such as the driver
>> isn't loaded, adapter is suspended or closed), mailbox irq won't be
>> triggered and VF driver will disable it via PCI_VF_MIGRATION_CAP
>> reg. These case will be resolved later.
>>
>> Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
>
> I have to say, I was much more interested in the idea
> of tracking dirty memory. I have some thoughts about
> that one - did you give up on it then?

The tracking of dirty pages still needs to be addressed unless the
interface is being downed before migration even starts which based on
other comments I am assuming is not the case.

I still feel that having a means of marking a page as being dirty when
it is unmapped would be the best way to go.  That way you only have to
update the DMA API instead of messing with each and every driver
trying to add code to force the page to be dirtied.

- Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver Lan Tianyu <tianyu.lan@intel.com> - 2015-11-24 15:00 +0100
  Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf  driver "Michael S. Tsirkin" <mst@redhat.com> - 2015-11-24 22:30 +0100
    Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver Alexander Duyck <alexander.duyck@gmail.com> - 2015-11-25 06:40 +0100
    Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf  driver Lan Tianyu <tianyu.lan@intel.com> - 2015-11-25 07:00 +0100
      Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf  driver "Michael S. Tsirkin" <mst@redhat.com> - 2015-11-25 13:30 +0100
        Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf  driver "Lan, Tianyu" <tianyu.lan@intel.com> - 2015-11-25 17:10 +0100
          Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf  driver "Michael S. Tsirkin" <mst@redhat.com> - 2015-11-25 17:30 +0100
          Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver Alexander Duyck <alexander.duyck@gmail.com> - 2015-11-25 17:30 +0100
            Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf  driver "Michael S. Tsirkin" <mst@redhat.com> - 2015-11-25 17:40 +0100
              Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver Alexander Duyck <alexander.duyck@gmail.com> - 2015-11-25 18:30 +0100

csiph-web