Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1275775

Re: [PATCH] ahci: don't use MSI when PCI is disabled

Show all headers | View raw

On Monday 23 November 2015 09:25:38 Dan Williams wrote:
> 
> If we had an "static inline ahci_irq_vector(int port)"  helper to
> compile out the struct msix_entry de-reference would that be
> sufficient?

Yes, that is probably a nicer way to do it. We should then also do
something like this:

@@ -2510,7 +2513,8 @@ int ahci_host_activate(struct ata_host *host, struct scsi_host_template *sht)
 	int irq = hpriv->irq;
 	int rc;
 
-	if (hpriv->flags & (AHCI_HFLAG_MULTI_MSI | AHCI_HFLAG_MULTI_MSIX))
+	if (IS_ENABLED(CONFIG_PCI_MSI) && \
+	    hpriv->flags & (AHCI_HFLAG_MULTI_MSI | AHCI_HFLAG_MULTI_MSIX))
 		rc = ahci_host_activate_multi_irqs(host, sht);
 	else if (hpriv->flags & AHCI_HFLAG_EDGE_IRQ)
 		rc = ata_host_activate(host, irq, ahci_single_edge_irq_intr,

which will let gcc leave out the entire ahci_host_activate_multi_irqs()
function but still flag compile errors in it even if CONFIG_PCI is
disabled.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ahci: don't use MSI when PCI is disabled Arnd Bergmann <arnd@arndb.de> - 2015-11-23 10:50 +0100
  Re: [PATCH] ahci: don't use MSI when PCI is disabled Dan Williams <dan.j.williams@intel.com> - 2015-11-23 18:30 +0100
    Re: [PATCH] ahci: don't use MSI when PCI is disabled Arnd Bergmann <arnd@arndb.de> - 2015-11-23 20:40 +0100

csiph-web