Re: [PATCH] sched: idle: move need_resched check after function rcu_idle_enter

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sched: idle: move need_resched check after function rcu_idle_enter
Date	2015-11-23 19:00 +0100
Message-ID	<qy3zc-55c-5@gated-at.bofh.it> (permalink)
References	<qxclb-3eb-1@gated-at.bofh.it> <qxZ2z-29g-47@gated-at.bofh.it> <qy3pw-51A-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 23, 2015 at 09:42:06AM -0800, Lianwei Wang wrote:
> Issue was found on ARM/Qcom platform, but I think it is applicable to
> other platforms as well.  I add a BUG_ON after rcu_enter_idle to catch
> it. The Qcom's cpuidle driver is not in mainline kernel yet.


A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?


And I suspect that your qualcom thing doesn't have TIF_POLLING_NRFLAG
either, which would introduce another need_resched() test after the
rcu_enter_idle() call.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] sched: idle: move need_resched check after function rcu_idle_enter Lianwei Wang <lianwei.wang@gmail.com> - 2015-11-21 10:10 +0100
  Re: [PATCH] sched: idle: move need_resched check after function  rcu_idle_enter Peter Zijlstra <peterz@infradead.org> - 2015-11-23 14:10 +0100
    Re: [PATCH] sched: idle: move need_resched check after function rcu_idle_enter Lianwei Wang <lianwei.wang@gmail.com> - 2015-11-23 18:50 +0100
      Re: [PATCH] sched: idle: move need_resched check after function  rcu_idle_enter Peter Zijlstra <peterz@infradead.org> - 2015-11-23 19:00 +0100
        Re: [PATCH] sched: idle: move need_resched check after function rcu_idle_enter Lianwei Wang <lianwei.wang@gmail.com> - 2015-11-23 21:10 +0100
  Re: [PATCH] sched: idle: move need_resched check after function  rcu_idle_enter Peter Zijlstra <peterz@infradead.org> - 2015-11-23 19:00 +0100

csiph-web