Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1275630

Re: [PATCH v3 1/6] PCI: designware: remove wrong io_base assignment

Show all headers | View raw

On Monday 23 November 2015 18:23:47 Stanimir Varbanov wrote:
> >>
> >> Fixes: 0021d22b73d6 ("PCI: designware: Use of_pci_get_host_bridge_resources()
> >> to parse DT")
> >> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> 
> I think the bug is introduced in:
> 
> cbce7900598c ("PCI: designware: Make driver arch-agnostic")
> 
> cause the io_base is correctly calculated in 0021d22b73d6, do you agree?


I think cbce7900598c just slightly changes the io_base value, but
it's still referring to a bus address, not a cpu address, both before
and after the patch.

0021d22b73d6 hower seems to remove the correct 'pp->io_base = range.cpu_addr;'
and replaces it with 'pp->io_base = pp->io->start;', so it's now in
the wrong address space.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/6] PCI: designware: remove wrong io_base assignment Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2015-11-23 10:30 +0100
  Re: [PATCH v3 1/6] PCI: designware: remove wrong io_base assignment Arnd Bergmann <arnd@arndb.de> - 2015-11-23 11:10 +0100
    RE: [PATCH v3 1/6] PCI: designware: remove wrong io_base assignment Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2015-11-23 11:30 +0100
      Re: [PATCH v3 1/6] PCI: designware: remove wrong io_base assignment Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2015-11-23 17:30 +0100
        Re: [PATCH v3 1/6] PCI: designware: remove wrong io_base assignment Arnd Bergmann <arnd@arndb.de> - 2015-11-23 17:50 +0100
          Re: [PATCH v3 1/6] PCI: designware: remove wrong io_base assignment Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2015-11-24 10:30 +0100

csiph-web