Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1275561

Re: [PATCH] memcg: fix memory.high target

Show all headers | View raw

On Mon, Nov 23, 2015 at 03:22:31PM +0300, Vladimir Davydov wrote:
> When the memory.high threshold is exceeded, try_charge() schedules a
> task_work to reclaim the excess. The reclaim target is set to the number
> of pages requested by try_charge(). This is wrong, because try_charge()
> usually charges more pages than requested (batch > nr_pages) in order to
> refill per cpu stocks. As a result, a process in a cgroup can easily
> exceed memory.high significantly when doing a lot of charges w/o
> returning to userspace (e.g. reading a file in big chunks).
> 
> Fix this issue by assuring that when exceeding memory.high a process
> reclaims as many pages as were actually charged (i.e. batch).
> 
> Signed-off-by: Vladimir Davydov <vdavydov@virtuozzo.com>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] memcg: fix memory.high target Vladimir Davydov <vdavydov@virtuozzo.com> - 2015-11-23 13:30 +0100
  Re: [PATCH] memcg: fix memory.high target Johannes Weiner <hannes@cmpxchg.org> - 2015-11-23 17:20 +0100
  Re: [PATCH] memcg: fix memory.high target Michal Hocko <mhocko@kernel.org> - 2015-11-24 17:40 +0100

csiph-web