Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1275426

Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page reference manipulation

Show all headers | View raw

On Mon, 23 Nov 2015 17:28:05 +0900
Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:

> On Fri, Nov 20, 2015 at 11:42:25AM -0500, Steven Rostedt wrote:
> > On Fri, 20 Nov 2015 15:33:25 +0900
> > Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:
> > 
> >   
> > > Steven, is it possible to add tracepoint to inlined fucntion such as
> > > get_page() in include/linux/mm.h?  
> > 
> > I highly recommend against it. The tracepoint code adds a bit of bloat,
> > and if you inline it, you add that bloat to every use case. Also, it  
> 
> Is it worse than adding function call to my own stub function into
> inlined function such as get_page(). I implemented it as following.
> 
> get_page()
> {
>         atomic_inc()
>         stub_get_page()
> }
> 
> stub_get_page() in foo.c
> {
>         trace_page_ref_get_page()
> }

Now you just slowed down the fast path. But what you could do is:

get_page()
{
	atomic_inc();
	if (trace_page_ref_get_page_enabled())
		stub_get_page();
}

Now that "trace_page_ref_get_page_enabled()" will turn into:

	if (static_key_false(&__tracepoint_page_ref_get_page.key)) {

which is a jump label (nop when disabled, a jmp when enabled). That's
less bloat but doesn't solve the include problem. You still need to add
the include of that will cause havoc with other tracepoints.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Vlastimil Babka <vbabka@suse.cz> - 2015-11-18 16:40 +0100
  Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Minchan Kim <minchan@kernel.org> - 2015-11-19 08:00 +0100
  Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2015-11-20 07:40 +0100
    Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Steven Rostedt <rostedt@goodmis.org> - 2015-11-20 17:50 +0100
      Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2015-11-23 09:30 +0100
        Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Steven Rostedt <rostedt@goodmis.org> - 2015-11-23 15:30 +0100
          Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2015-11-24 03:00 +0100
          Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page  reference manipulation Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2015-11-24 03:20 +0100

csiph-web