Re: [PATCH 6/7] cputime: Introduce vtime accounting check for readers

From	Frederic Weisbecker <fweisbec@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/7] cputime: Introduce vtime accounting check for readers
Date	2015-11-23 15:20 +0100
Message-ID	<qy08i-2R4-19@gated-at.bofh.it> (permalink)
References	<qwzDb-2M9-9@gated-at.bofh.it> <qwzDb-2M9-7@gated-at.bofh.it> <qwE0a-5Mi-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Nov 19, 2015 at 09:28:28PM +0100, Peter Zijlstra wrote:
> On Thu, Nov 19, 2015 at 04:47:33PM +0100, Frederic Weisbecker wrote:
> > +++ b/include/linux/vtime.h
> > @@ -17,9 +17,20 @@ static inline bool vtime_accounting_cpu_enabled(void) { return true; }
> >  #endif /* CONFIG_VIRT_CPU_ACCOUNTING_NATIVE */
> >  
> >  #ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN
> > +/*
> > + * Checks if vtime is enabled on some CPU. Cputime readers want to be careful
> > + * in that case and compute the tickless cputime.
> > + * For now vtime state is tied to context tracking. We might want to decouple
> > + * those later if necessary.
> > + */
> > +static inline bool vtime_accounting_enabled(void)
> > +{
> > +	return context_tracking_is_enabled();
> > +}
> 
> Should this not also include a definition of this function for
> CONFIG_VIRT_CPU_ACCOUNTING_NATIVE and CONFIG_VIRT_CPU_ACCOUNTING ?

I could but I haven't found any user of it yet for others than
CONFIG_VIRT_CPU_ACCOUNTING_GEN. The NATIVE version, when enabled, runs on
all CPUs anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 6/7] cputime: Introduce vtime accounting check for readers Frederic Weisbecker <fweisbec@gmail.com> - 2015-11-19 16:50 +0100
  Re: [PATCH 6/7] cputime: Introduce vtime accounting check for readers Peter Zijlstra <peterz@infradead.org> - 2015-11-19 21:30 +0100
    Re: [PATCH 6/7] cputime: Introduce vtime accounting check for readers Frederic Weisbecker <fweisbec@gmail.com> - 2015-11-23 15:20 +0100
      Re: [PATCH 6/7] cputime: Introduce vtime accounting check for readers Peter Zijlstra <peterz@infradead.org> - 2015-11-23 15:40 +0100
        Re: [PATCH 6/7] cputime: Introduce vtime accounting check for readers Frederic Weisbecker <fweisbec@gmail.com> - 2015-11-23 16:30 +0100

csiph-web