Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Delete unnecessary checks before the function call "kfree_skb"

From	Marek Lindner <mareklindner@neomailbox.ch>
Newsgroups	linux.kernel
Subject	Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Delete unnecessary checks before the function call "kfree_skb"
Date	2015-11-21 23:10 +0100
Message-ID	<qxow2-2Zx-11@gated-at.bofh.it> (permalink)
References	<mSsDN-4wa-35@gated-at.bofh.it> <qv1ax-7t7-3@gated-at.bofh.it> <qv1ax-7t7-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sunday, November 15, 2015 09:43:26 SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 15 Nov 2015 08:04:43 +0100
> 
> The kfree_skb() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the calls is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  net/batman-adv/main.c           | 2 +-
>  net/batman-adv/network-coding.c | 4 +---
>  net/batman-adv/send.c           | 3 +--
>  3 files changed, 3 insertions(+), 6 deletions(-)

Applied in revision 77d84a6.

Thanks,
Marek

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Delete unnecessary checks before the function call "kfree_skb" Marek Lindner <mareklindner@neomailbox.ch> - 2015-11-21 23:10 +0100

csiph-web