Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1274758
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drivers: staging: vme: Fixed code style issues |
| Date | 2015-11-21 22:40 +0100 |
| Message-ID | <qxo30-2yb-11@gated-at.bofh.it> (permalink) |
| References | <qxo30-2yb-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, 2015-11-21 at 23:26 +0200, Egor Uleyskiy wrote: trivia: Some might consider this patch fixes too many issues in one patch and should be broken up into a patch series. > > diff --git a/drivers/staging/vme/devices/vme_pio2_core.c b/drivers/staging/vme/devices/vme_pio2_core.c [] > retval = vme_master_set(card->window, 1, card->base, 0x10000, VME_A24, > - (VME_SCT | VME_USER | VME_DATA), VME_D16); > + (VME_SCT | VME_USER | VME_DATA), VME_D16); unnecessary parentheses around VME_ constants > @@ -343,7 +343,7 @@ static int pio2_probe(struct vme_dev *vdev) > retval = vme_irq_request(vdev, card->irq_level, vec, > - &pio2_int, (void *)card); > + &pio2_int, (void *)card); unnecessary cast to (void *) here and in other places. You could fix these in follow-on patch(es) or revisions like a patch set of this one. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] drivers: staging: vme: Fixed code style issues Egor Uleyskiy <egor.ulieiskii@gmail.com> - 2015-11-21 22:40 +0100
Re: [PATCH] drivers: staging: vme: Fixed code style issues Joe Perches <joe@perches.com> - 2015-11-21 22:40 +0100
Re: [PATCH] drivers: staging: vme: Fixed code style issues Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-11-25 00:30 +0100
csiph-web