Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1275362
| From | Jiri Slaby <jslaby@suse.cz> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 3.12 04/72] iwlwifi: mvm: fix D3 firmware PN programming |
| Date | 2015-11-23 14:30 +0100 |
| Message-ID | <qxZlU-2hK-17@gated-at.bofh.it> (permalink) |
| References | <qxZ2y-29g-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Johannes Berg <johannes.berg@intel.com> 3.12-stable review patch. If anyone has any objections, please let me know. =============== commit 2cf5eb3ab7bb7f2e3a70edcef236cd62c87db030 upstream. The code to send the RX PN data (for each TID) to the firmware has a devastating bug: it overwrites the data for TID 0 with all the TID data, leaving the remaining TIDs zeroed. This will allow replays to actually be accepted by the firmware, which could allow waking up the system. Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: Luca Coelho <luciano.coelho@intel.com> Signed-off-by: Jiri Slaby <jslaby@suse.cz> --- drivers/net/wireless/iwlwifi/mvm/d3.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/iwlwifi/mvm/d3.c b/drivers/net/wireless/iwlwifi/mvm/d3.c index 417639f77b01..a25f608d8ab4 100644 --- a/drivers/net/wireless/iwlwifi/mvm/d3.c +++ b/drivers/net/wireless/iwlwifi/mvm/d3.c @@ -296,12 +296,12 @@ static void iwl_mvm_wowlan_program_keys(struct ieee80211_hw *hw, u8 *pn = seq.ccmp.pn; ieee80211_get_key_rx_seq(key, i, &seq); - aes_sc->pn = cpu_to_le64((u64)pn[5] | - ((u64)pn[4] << 8) | - ((u64)pn[3] << 16) | - ((u64)pn[2] << 24) | - ((u64)pn[1] << 32) | - ((u64)pn[0] << 40)); + aes_sc[i].pn = cpu_to_le64((u64)pn[5] | + ((u64)pn[4] << 8) | + ((u64)pn[3] << 16) | + ((u64)pn[2] << 24) | + ((u64)pn[1] << 32) | + ((u64)pn[0] << 40)); } data->use_rsc_tsc = true; break; -- 2.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 3.12 01/72] dm btree remove: fix a bug when rebalancing nodes after removal Jiri Slaby <jslaby@suse.cz> - 2015-11-23 14:10 +0100 [PATCH 3.12 07/72] ASoC: wm8904: Correct number of EQ registers Jiri Slaby <jslaby@suse.cz> - 2015-11-23 14:10 +0100 [PATCH 3.12 02/72] iwlwifi: dvm: fix D3 firmware PN programming Jiri Slaby <jslaby@suse.cz> - 2015-11-23 14:30 +0100 [PATCH 3.12 04/72] iwlwifi: mvm: fix D3 firmware PN programming Jiri Slaby <jslaby@suse.cz> - 2015-11-23 14:30 +0100 [PATCH 3.12 03/72] iwlwifi: fix firmware filename for 3160 Jiri Slaby <jslaby@suse.cz> - 2015-11-23 14:30 +0100 [PATCH 3.12 05/72] iommu/amd: Don't clear DTE flags when modifying it Jiri Slaby <jslaby@suse.cz> - 2015-11-23 14:30 +0100
csiph-web