Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1275402

Re: [PATCH 1/1] HID: multitouch: enable palm rejection if device implements confidence usage

Show all headers | View raw

On Fri, Nov 20, 2015 at 11:21 AM, Allen Hung <allen_hung@dell.com> wrote:
> The usage Confidence is mandary to Windows Precision Touchpad devices. The
> appearance of this usage is checked in hidinput_connect but the quirk
> MT_QUIRK_VALID_IS_CONFIDENCE is not applied to device accordingly.
> Apply this quirk and also remove quirk MT_QUIRK_ALWAYS_VALID to enable palm
> rejection for the WIN 8 touchpad devices which have implemented usage
> Confidence in its input reports.
>
> Tested on Dell XPS 13 laptop.
>
> Signed-off-by: Allen Hung <allen_hung@dell.com>
> ---

No side effects on non touchpads as reported by my tests.
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Cheers,
Benjamin

>  drivers/hid/hid-multitouch.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 426b2f1..13aeff9 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -448,6 +448,11 @@ static int mt_touch_input_mapping(struct hid_device *hdev, struct hid_input *hi,
>                         mt_store_field(usage, td, hi);
>                         return 1;
>                 case HID_DG_CONFIDENCE:
> +                       if (cls->name == MT_CLS_WIN_8 &&
> +                               field->application == HID_DG_TOUCHPAD) {
> +                               cls->quirks &= ~MT_QUIRK_ALWAYS_VALID;
> +                               cls->quirks |= MT_QUIRK_VALID_IS_CONFIDENCE;
> +                       }
>                         mt_store_field(usage, td, hi);
>                         return 1;
>                 case HID_DG_TIPSWITCH:
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] HID: multitouch: enable palm rejection if device implements confidence usage Allen Hung <allen_hung@dell.com> - 2015-11-20 11:40 +0100
  Re: [PATCH 1/1] HID: multitouch: enable palm rejection if device  implements confidence usage Benjamin Tissoires <benjamin.tissoires@gmail.com> - 2015-11-23 14:50 +0100
  Re: [PATCH 1/1] HID: multitouch: enable palm rejection if device  implements confidence usage Jiri Kosina <jikos@kernel.org> - 2015-11-26 15:30 +0100

csiph-web