Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1275220

Re: nfnetlink warnings

Show all headers | View raw

On 11/23/2015 10:54 AM, Borislav Petkov wrote:
> Hi Michael,
> 
> On Mon, Nov 23, 2015 at 10:49:34AM +0100, Michael Wang wrote:
>> Why not just initialized it as NULL, or mark it as uninitialized_var()?
> 
> because I'd like us to save us the redundant NULL initialization in the
> if-case.

Well, I would vote initialized with NULL, rather than use another else
branch to do the same thing.

> 
> I'm not saying any of the approaches are good visually, though. Who
> knows, someone might have a better idea like, maybe "Oh, I wanted to
> rewrite that code and this handlong is going to be different anyway ..."
> or so. Or something to that effect.

Who want to do that would take responsibility to make an else branch at
that time, but reserve the branch at this moment sounds unnecessary, and
not that pretty frankly speaking.

> 
> Btw, please do not top-post.

Enjoy ;-)

Regards,
Michael Wang

> 
> Thanks.
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

nfnetlink warnings Borislav Petkov <bp@alien8.de> - 2015-11-23 10:40 +0100
  Re: nfnetlink warnings Michael Wang <yun.wang@profitbricks.com> - 2015-11-23 10:50 +0100
    Re: nfnetlink warnings Borislav Petkov <bp@alien8.de> - 2015-11-23 11:00 +0100
      Re: nfnetlink warnings Michael Wang <yun.wang@profitbricks.com> - 2015-11-23 11:30 +0100
        Re: nfnetlink warnings Michael Wang <yun.wang@profitbricks.com> - 2015-11-23 11:40 +0100
        Re: nfnetlink warnings Pablo Neira Ayuso <pablo@netfilter.org> - 2015-11-23 11:40 +0100
        Re: nfnetlink warnings Borislav Petkov <bp@alien8.de> - 2015-11-23 11:40 +0100

csiph-web