Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1275148

Re: [linux-sunxi] [PATCH v2 2/5] clk: sunxi: Add driver for the H3 THS clock

Show all headers | View raw

On Mon, Nov 23, 2015 at 09:02:49AM +0100, Josef Gajdusek wrote:
> This patch adds a driver for the THS clock which is present on the
> Allwinner H3.
> 
> Signed-off-by: Josef Gajdusek <atx@atx.name>
> ---

Hello
Just a minor comment below.

> +static void __init sun8i_h3_ths_clk_setup(struct device_node *node)
> +{
> +	struct clk *clk;
> +	struct clk_gate *gate;
> +	struct clk_divider *div;
> +	const char *parent;
> +	const char *clk_name = node->name;
> +	void __iomem *reg;
> +	int err;
> +
> +	reg = of_io_request_and_map(node, 0, of_node_full_name(node));
> +
> +	if (IS_ERR(reg))
> +		return;
> +
> +	gate = kzalloc(sizeof(*gate), GFP_KERNEL);
> +	if (!gate)
> +		goto err_unmap;
> +
> +	div = kzalloc(sizeof(*gate), GFP_KERNEL);
copy/paste error, you mean sizeof(*div) ?

> +	if (!div)
> +		goto err_gate_free;
> +
> +	of_property_read_string(node, "clock-output-names", &clk_name);

Regards
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] sunxi: THS support Josef Gajdusek <atx@atx.name> - 2015-11-23 09:10 +0100
  [PATCH v2 3/5] thermal: Add a driver for the Allwinner THS sensor Josef Gajdusek <atx@atx.name> - 2015-11-23 09:10 +0100
    Re: [PATCH v2 3/5] thermal: Add a driver for the Allwinner THS sensor Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-11-24 09:50 +0100
      Re: [linux-sunxi] Re: [PATCH v2 3/5] thermal: Add a driver for    the Allwinner THS sensor "Josef Gajdusek" <atx@atx.name> - 2015-11-25 12:20 +0100
  [PATCH v2 2/5] clk: sunxi: Add driver for the H3 THS clock Josef Gajdusek <atx@atx.name> - 2015-11-23 09:10 +0100
    Re: [linux-sunxi] [PATCH v2 2/5] clk: sunxi: Add driver for the H3  THS clock LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-11-23 10:20 +0100
    Re: [linux-sunxi] [PATCH v2 2/5] clk: sunxi: Add driver for the H3  THS clock Priit Laes <plaes@plaes.org> - 2015-11-23 11:40 +0100
    Re: [PATCH v2 2/5] clk: sunxi: Add driver for the H3 THS clock Rob Herring <robh@kernel.org> - 2015-11-23 22:40 +0100

csiph-web