Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1275151

[PATCH] leds/powernv : removing NULL check

From Saurabh Sengar <saurabh.truth@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] leds/powernv : removing NULL check
Date 2015-11-23 10:30 +0100
Message-ID <qxVBE-8jJ-3@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


no need to explicitly check for pointer to be null,
of_prop_next_string anyways return NULL, if passed pointer is NULL
and hence loop will continue

Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
---
 drivers/leds/leds-powernv.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/leds/leds-powernv.c b/drivers/leds/leds-powernv.c
index 1e75e1f..bc2d76e 100644
--- a/drivers/leds/leds-powernv.c
+++ b/drivers/leds/leds-powernv.c
@@ -256,8 +256,6 @@ static int powernv_led_classdev(struct platform_device *pdev,
 
 	for_each_child_of_node(led_node, np) {
 		p = of_find_property(np, "led-types", NULL);
-		if (!p)
-			continue;
 
 		while ((cur = of_prop_next_string(p, cur)) != NULL) {
 			powernv_led = devm_kzalloc(dev, sizeof(*powernv_led),
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] leds/powernv : removing NULL check Saurabh Sengar <saurabh.truth@gmail.com> - 2015-11-23 10:30 +0100
  Re: [PATCH] leds/powernv : removing NULL check Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-11-23 13:40 +0100
  Re: [PATCH] leds/powernv : removing NULL check Vasant Hegde <hegdevasant@linux.vnet.ibm.com> - 2015-11-25 15:50 +0100
    Re: [PATCH] leds/powernv : removing NULL check Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-11-25 16:20 +0100
      Re: [PATCH] leds/powernv : removing NULL check Vasant Hegde <hegdevasant@linux.vnet.ibm.com> - 2015-11-25 17:50 +0100

csiph-web