Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1275129
| From | Rasmus Villemoes <linux@rasmusvillemoes.dk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v1 3/7] test_hexdump: go through all possible lengths of buffer |
| Date | 2015-11-23 10:00 +0100 |
| Message-ID | <qxV8B-7TP-5@gated-at.bofh.it> (permalink) |
| References | <qtGBb-5cy-7@gated-at.bofh.it> <qtGBd-5cy-35@gated-at.bofh.it> <qwuk9-7U6-11@gated-at.bofh.it> <qwXcu-1li-19@gated-at.bofh.it> |
| Organization | D03 |
On Fri, Nov 20 2015, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Thu, 2015-11-19 at 11:07 +0100, Rasmus Villemoes wrote: >> >> >> Why keep the variable l when it is just a synonym for the new >> parameter buflen? It is quite confusing that you change some but not >> all occurrences of l to buflen. If you want to make the diff minimal >> but still have a descriptive parameter name, just keep the 'size_t l >> = >> buflen;' assignment and don't otherwise refer to buflen. But I think >> it's better to eliminate 'l' and just change everything to >> buflen. Don't mix the two approaches, though. > > Okay, I got it for the future, though the series is already in linux- > next, so do we really need to re-hack half of it because of that? Stuff in -next isn't set in stone. I'm pretty sure Andrew can replace one set of patches with another. Rasmus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v1 3/7] test_hexdump: go through all possible lengths of buffer Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-11-19 11:10 +0100
Re: [PATCH v1 3/7] test_hexdump: go through all possible lengths of buffer Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-11-20 18:00 +0100
Re: [PATCH v1 3/7] test_hexdump: go through all possible lengths of buffer Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-11-23 10:00 +0100
Re: [PATCH v1 3/7] test_hexdump: go through all possible lengths of buffer Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-26 16:30 +0100
csiph-web