Re: [PATCH v2] zram: Prevent page allocation failure during zcomp_strm_alloc

From	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] zram: Prevent page allocation failure during zcomp_strm_alloc
Date	2015-11-23 09:20 +0100
Message-ID	<qxUvV-7DO-15@gated-at.bofh.it> (permalink)
References	<qxQLD-5bV-5@gated-at.bofh.it> <qxU2R-7ds-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On (11/23/15 16:43), Sergey Senozhatsky wrote:
[..]
> agree. we also would want to switch from vzalloc() to
> 	__vmalloc_node_flags(size, NUMA_NO_NODE,
> 			GFP_NOIO | __GFP_HIGHMEM |  __GFP_ZERO)

[..]
> > So, Kyeongdon's patch will remove warning overhead and likely to
> > make zcomp_stram_alloc successful with vmalloc so I want to
> > roll it out first. And let's add a WARN_ON_ONCE to detect of
> > failure and rethink it when we receive such report.

hm... for k{z,m}alloc() it does reduce the warning overhead, but not
for vmalloc() -> warn_alloc_failed() [in theory]. So I guess, I'll
change vmalloc() to

	__vmalloc(XXX,
		GFP_NOIO | __GFP_NOWARN | __GFP_HIGHMEM | __GFP_ZERO,
		PAGE_KERNEL);

/* passing __GFP_NOWARN */.

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] zram: Prevent page allocation failure during  zcomp_strm_alloc Minchan Kim <minchan@kernel.org> - 2015-11-23 05:20 +0100
  Re: [PATCH v2] zram: Prevent page allocation failure during  zcomp_strm_alloc Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-23 08:50 +0100
    Re: [PATCH v2] zram: Prevent page allocation failure during  zcomp_strm_alloc Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-23 09:20 +0100

csiph-web